fix(stop,clean): scope cleanup to foc-devnet images, not the foc- prefix#111
Merged
fix(stop,clean): scope cleanup to foc-devnet images, not the foc- prefix#111
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens stop/clean Docker cleanup so it targets foc-devnet-owned resources (by image identity) rather than sweeping up anything that happens to share the foc- prefix, addressing conflicts with other foc-* containers on a developer machine.
Changes:
- Added an
is_foc_devnet_image(...)helper to identify foc-devnet images (optionally tagged). - Replaced prefix-based container discovery with image-based discovery for log persistence and dead-container removal.
- Updated
stopandcleanto use the new foc-devnet container/image identification logic.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/docker/mod.rs |
Re-exports the renamed container listing helper used by stop/log cleanup. |
src/docker/logs.rs |
Switches container selection from image-prefix matching to foc-devnet image identification. |
src/constants.rs |
Adds is_foc_devnet_image(...) to centralize foc-devnet image identification. |
src/commands/stop.rs |
Updates force-kill logic to target containers by foc-devnet images instead of name prefix; adjusts network cleanup filter. |
src/commands/clean.rs |
Updates image removal to target only foc-devnet images rather than foc-* prefix. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
rvagg
force-pushed
the
rvagg/careful-cleanup
branch
from
14afdbd to
4ba8124
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run other foc-* containers on my machine so this is a problem ...