Fix issues reported by zoeontheloose + Undefined Behaviour in ControlSwitches#3541
Open
Ghabry wants to merge 6 commits intoEasyRPG:masterfrom
Open
Fix issues reported by zoeontheloose + Undefined Behaviour in ControlSwitches#3541Ghabry wants to merge 6 commits intoEasyRPG:masterfrom
Ghabry wants to merge 6 commits intoEasyRPG:masterfrom
Conversation
More compatible with RPG_RT. Prior we accepted any value > 1 for Flip (2) Fix EasyRPG#3535
27 tasks
carstene1ns
approved these changes
May 4, 2026
|
|
||
| out = 0; | ||
|
|
||
| if (!(str.size() > 0 && str.size() <= 6)) { |
| return false; | ||
| } | ||
|
|
||
| out = static_cast<uint32_t>(result); |
Member
There was a problem hiding this comment.
The casting here is a bit ugly, result variable is not really needed, when doing all unsigned. !in_range could be simplified to >=32 as well then.
| out += static_cast<uint32_t>(result << (chidx * 5)); | ||
| } | ||
|
|
||
| return out; |
Member
There was a problem hiding this comment.
what if out is 0, is this not valid?
|
|
||
| if (start == end) { | ||
| if (val < 2) { | ||
| if (val == 0 || val == 1) { |
Member
There was a problem hiding this comment.
Maybe any log entry/assert for val>2?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various small stuff:
Most were reported by zoeontheloose in our community because is shadowbanned on GitHub: https://community.easyrpg.org/t/various-small-bug-reports-regarding-maniacs-features/1691