Drop range related attributes on load#3072
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3072 +/- ##
=======================================
Coverage 96.15% 96.16%
=======================================
Files 270 270
Lines 15807 15821 +14
=======================================
+ Hits 15200 15214 +14
Misses 607 607 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hb326
approved these changes
May 12, 2026
Contributor
hb326
left a comment
There was a problem hiding this comment.
I just tested the recipe with the new GPCP data with this fix, and everything worked fine. Thanks for the fix, @bouweandela!
schlunma
reviewed
May 13, 2026
schlunma
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Drop value range-related attributes on load because they are very likely to be invalidated by any preprocessor function that is applied afterwards. They are not needed anymore after loading because they have already been interpreted.
This should fix the issue reported in ESMValGroup/ESMValTool#4434
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: