Skip to content

Drop range related attributes on load#3072

Merged
schlunma merged 4 commits into
mainfrom
drop-range-attrs
May 13, 2026
Merged

Drop range related attributes on load#3072
schlunma merged 4 commits into
mainfrom
drop-range-attrs

Conversation

@bouweandela
Copy link
Copy Markdown
Member

@bouweandela bouweandela commented May 11, 2026

Description

Drop value range-related attributes on load because they are very likely to be invalidated by any preprocessor function that is applied afterwards. They are not needed anymore after loading because they have already been interpreted.

This should fix the issue reported in ESMValGroup/ESMValTool#4434


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added the preprocessor Related to the preprocessor label May 11, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.16%. Comparing base (77013ca) to head (a689714).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3072   +/-   ##
=======================================
  Coverage   96.15%   96.16%           
=======================================
  Files         270      270           
  Lines       15807    15821   +14     
=======================================
+ Hits        15200    15214   +14     
  Misses        607      607           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bouweandela bouweandela marked this pull request as ready for review May 11, 2026 21:55
@bouweandela bouweandela requested a review from hb326 May 11, 2026 21:56
@bouweandela bouweandela moved this to Looking for review in ESMValTool Workshop May 2026 May 11, 2026
Copy link
Copy Markdown
Contributor

@hb326 hb326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested the recipe with the new GPCP data with this fix, and everything worked fine. Thanks for the fix, @bouweandela!

@hb326 hb326 moved this from Looking for review to In review in ESMValTool Workshop May 2026 May 12, 2026
@hb326 hb326 moved this from In review to Done in ESMValTool Workshop May 2026 May 12, 2026
@hb326 hb326 moved this from Done to In review in ESMValTool Workshop May 2026 May 12, 2026
Comment thread esmvalcore/preprocessor/_io.py
@schlunma schlunma merged commit af39db6 into main May 13, 2026
4 checks passed
@schlunma schlunma deleted the drop-range-attrs branch May 13, 2026 12:23
@github-project-automation github-project-automation Bot moved this from In review to Done in ESMValTool Workshop May 2026 May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preprocessor Related to the preprocessor

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants