Skip to content

Fix ERS tests for compsets with WW3#649

Merged
billsacks merged 2 commits into
ESCOMP:mainfrom
alperaltuntas:fix_ww3_histaux
May 6, 2026
Merged

Fix ERS tests for compsets with WW3#649
billsacks merged 2 commits into
ESCOMP:mainfrom
alperaltuntas:fix_ww3_histaux

Conversation

@alperaltuntas
Copy link
Copy Markdown
Member

@alperaltuntas alperaltuntas commented Apr 21, 2026

Description of changes

Set histaux_wav2med_file1_ntperfile to 1 for ERS and ERI test cases.

Specific notes

No answer changes

Testing performed

ERS.TL319_t232_wg37.GW_JRA.derecho_intel

@alperaltuntas alperaltuntas marked this pull request as ready for review May 5, 2026 22:27
@alperaltuntas alperaltuntas requested a review from billsacks May 5, 2026 22:27
Copy link
Copy Markdown
Member

@billsacks billsacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just approved... but actually, thinking about it more: can you please add a comment here saying why this is needed? I think I vaguely remember why, but a comment will help when we look back at this in the future.

@alperaltuntas
Copy link
Copy Markdown
Member Author

@billsacks The restart tests were failing because the WW3 aux history files contain multiple time samples, which leads to mismatched filenames and contents between the initial and restart runs. This change writes output to daily files to ensure consistency across initial and restart filenames.

@billsacks
Copy link
Copy Markdown
Member

@alperaltuntas thank you for the reminder. I should have been more clear: I was thinking it could be good to add a comment like that in the xml file itself - or a comment in the xml that points to your comment here - so that this somewhat unintuitive setting will be more obvious when we look back at it later.

@alperaltuntas
Copy link
Copy Markdown
Member Author

@alperaltuntas thank you for the reminder. I should have been more clear: I was thinking it could be good to add a comment like that in the xml file itself - or a comment in the xml that points to your comment here - so that this somewhat unintuitive setting will be more obvious when we look back at it later.

Done.

Copy link
Copy Markdown
Member

@billsacks billsacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@billsacks billsacks merged commit 56d5812 into ESCOMP:main May 6, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants