Generalize cloud chemistry#1559
Open
fvitt wants to merge 15 commits into
Open
Conversation
modified: src/chemistry/modal_aero/aero_model.F90 modified: src/chemistry/modal_aero/modal_aero_gasaerexch.F90
modified: src/chemistry/aerosol/aerosol_properties_mod.F90 modified: src/chemistry/aerosol/bulk_aerosol_properties_mod.F90 modified: src/chemistry/aerosol/carma_aerosol_properties_mod.F90 modified: src/chemistry/aerosol/modal_aerosol_properties_mod.F90
… mam7 modified: src/chemistry/aerosol/mo_setsox.F90 modified: src/chemistry/bulk_aero/aero_model.F90 modified: src/chemistry/bulk_aero/sox_cldaero_mod.F90 modified: src/chemistry/carma_aero/aero_model.F90 modified: src/chemistry/carma_aero/sox_cldaero_mod.F90 modified: src/chemistry/modal_aero/aero_model.F90 modified: src/chemistry/modal_aero/sox_cldaero_mod.F90
renamed: src/chemistry/modal_aero/sox_cldaero_mod.F90 -> src/chemistry/aerosol/sox_cldaero_mod.F90 deleted: src/chemistry/bulk_aero/sox_cldaero_mod.F90 deleted: src/chemistry/carma_aero/sox_cldaero_mod.F90 modified: src/chemistry/aerosol/mo_setsox.F90 modified: src/chemistry/aerosol/sox_cldaero_mod.F90
modified: src/chemistry/aerosol/mo_setsox.F90 modified: src/chemistry/aerosol/sox_cldaero_mod.F90 modified: src/chemistry/bulk_aero/aero_model.F90 modified: src/chemistry/carma_aero/aero_model.F90 modified: src/chemistry/modal_aero/aero_model.F90
modified: src/chemistry/aerosol/mo_setsox.F90
modified: src/chemistry/aerosol/aerosol_state_mod.F90 modified: src/chemistry/aerosol/carma_aerosol_state_mod.F90 modified: src/chemistry/aerosol/modal_aerosol_state_mod.F90 modified: src/chemistry/aerosol/sox_cldaero_mod.F90
modified: src/chemistry/geoschem/chemistry.F90
jimmielin
reviewed
May 15, 2026
|
|
||
| ! Initialize aqueous chem | ||
| CALL SOx_inti() | ||
| CALL SOx_inti(aero_props) |
Member
There was a problem hiding this comment.
@jimmielin will check whether this call is needed if GEOS-Chem doesn't call setsox
Member
There was a problem hiding this comment.
It seems like this is needed to keep gas-surface exchange happy but the stub here is fine. I might add a suggested change in the full review to actually get the real MAM properties object here instead of the stub, in case GEOS-Chem needs it in the future.
jimmielin
requested changes
May 19, 2026
Comment on lines
+128
to
+134
| ! *** NOTE *** | ||
| ! should refactor this bit after merging to later cam tag -- where aero_props%model_is is avail | ||
| if (ntot_amode>0) then | ||
| if (.not.mode7) then | ||
| conc_obj%so4_fact = 1._r8 | ||
| end if | ||
| end if |
Member
There was a problem hiding this comment.
Does this need to be refactored now that model_is is available and this has been merged up?
Collaborator
Author
There was a problem hiding this comment.
I reworked the logic here
Fix dealloc in aero_model: use aerosol_instances_mod copy
modified: src/chemistry/aerosol/sox_cldaero_mod.F90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces aerosol model specific
sox_cldaero_modmodules for aqueous cloud chemistry with a generic aerosol model independent module. This expands on and makes use of the aerosol abstract interfaces.Closes #1428