Skip to content

ENG-1642 Discourse context overlay gets re-triggered every hover in a query block when view is render #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdroidian merged 4 commits into from
May 7, 2026
Merged

ENG-1642 Discourse context overlay gets re-triggered every hover in a query block when view is render #989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fd563d5
ENG-1642 Memoize results table to avoid redraws
maparent Apr 30, 2026
b0f4cf6
spurious includes
maparent May 1, 2026
57f54f0
Refactor ResultsView component to simplify menu icon visibility (#1006)
mdroidian May 7, 2026
a83a728
remove memo
mdroidian May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions apps/roam/src/components/results-view/ResultsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,13 +160,7 @@ export const CellEmbed = ({
);
};

export const CellRender = ({
content,
uid,
}: {
content: string;
uid: string;
}) => {
const CellRender = ({ content, uid }: { content: string; uid: string }) => {
const isPage = !!getPageTitleByPageUid(uid);
const displayString = isPage ? `[[${content}]]` : content;

Expand Down
17 changes: 9 additions & 8 deletions apps/roam/src/components/results-view/ResultsView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,9 +330,7 @@ const ResultsView: ResultsViewComponent = ({
settings.showSearchFilter,
);
const [showInterface, setShowInterface] = useState(settings.showInterface);
const [revealMenuIcons, setRevealMenuIcons] = useState(false);
const [showInputs, setShowInputs] = useState(settings.showInputs);
const hideMenuIcons = hideMenu || (!revealMenuIcons && !showInterface);
const [showAlias, setShowAlias] = useState(settings.showAlias);
const [isEditAlias, setIsEditAlias] = useState(false);
const [alias, setAlias] = useState(settings.alias);
Expand Down Expand Up @@ -452,13 +450,19 @@ const ResultsView: ResultsViewComponent = ({
() => views.filter((view) => view.mode !== "hidden").length,
[views],
);
const menuIconClassName = [
"roamjs-query-menu-icons",
hideMenu
? ""
: showInterface
? "roamjs-query-menu-icons-visible"
: "roamjs-query-menu-icons-hover",
].join(" ");

return (
<div
className={`roamjs-query-results-view relative w-full mode-${layout.mode}`}
ref={containerRef}
onMouseEnter={() => setRevealMenuIcons(true)}
onMouseLeave={() => setRevealMenuIcons(false)}
>
{showAlias && (
<div
Expand Down Expand Up @@ -580,10 +584,7 @@ const ResultsView: ResultsViewComponent = ({
/>
{header}
<div className="relative">
<div
style={hideMenuIcons ? { display: "none" } : {}}
className="absolute right-0 z-10 p-1"
>
<div className={menuIconClassName}>
{onRefresh && (
<Tooltip content={"Refresh Results"}>
<Button icon={"refresh"} minimal onClick={() => onRefresh()} />
Expand Down
14 changes: 14 additions & 0 deletions apps/roam/src/styles/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,20 @@
padding: 8px;
}

.roamjs-query-menu-icons {
position: absolute;
right: 0;
z-index: 10;
display: none;
padding: 4px;
}

.roamjs-query-menu-icons.roamjs-query-menu-icons-visible,
.roamjs-query-results-view:hover
.roamjs-query-menu-icons.roamjs-query-menu-icons-hover {
display: block;
}

/* Solves dot-tags (.#sticky, .#meeting) flashing on when hovering anywhere on the
Query Table. Roam shows them via .rm-block__self:hover and the entire table lives
in one block, so we scope visibility to the individual cell instead. */
Expand Down
Loading