Conversation
Poor grammar. Co-authored-by: Peter Holloway <peter.holloway@diamond.ac.uk>
… having an effect when running plans - you'll still get the Unauthorised request message"
…ted to return some more details
rebased from main to fix merge conflicts --------- Co-authored-by: Shreelakshmi Iyengar <shreelakshmi.iyengar@diamond.ac.uk> Co-authored-by: Zoheb Shaikh <zoheb.shaikh@diamond.ac.uk> Co-authored-by: Daniel Fernandes <65790536+dan-fernandes@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Zoheb Shaikh <26975142+ZohebShaikh@users.noreply.github.com> Co-authored-by: Abigail Emery <abigail.emery@diamond.ac.uk> Co-authored-by: oliwenmandiamond <136330507+oliwenmandiamond@users.noreply.github.com> Co-authored-by: Peter Holloway <peter.holloway@diamond.ac.uk> Co-authored-by: NeilSmithDLS <118457264+NeilSmithDLS@users.noreply.github.com>
Removed duplicate BlueskyRequestError exception class from rest.py.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1491 +/- ##
==========================================
- Coverage 95.27% 95.22% -0.05%
==========================================
Files 43 43
Lines 3173 3184 +11
==========================================
+ Hits 3023 3032 +9
- Misses 150 152 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It wasn't mentioned in the original issue but the
|
7a76c2c to
61e973a
Compare
tpoliaw
left a comment
There was a problem hiding this comment.
Much better errors for the main error cases, thanks.
Co-authored-by: Peter Holloway <peter.holloway@diamond.ac.uk>
|
Very nit: Could you remove the issue numbers in the PR title and just make sure they are linked in the commit message when you squash it? Also capitalise the "I" in improve. |
d5535b9 to
1b654cf
Compare
tpoliaw
left a comment
There was a problem hiding this comment.
I think this is enough of an improvement that it can go in and any further changes can be their own PR.
Fixes #1379
Fixes #1409
Both issues related to error handling in the REST client.
1379 - Catches 'UnauthorisedAccessErrorexplicitly instead of string-matching onBlueskyRemoteControlError`.
1409 - Expands the exception hierarchy so each
HTTP status code raises a distinct typed exception rather than bundling
everything into BlueskyRemoteControlError.
Tests