fix: adds parent config sections if not existing#31
Open
ElvenSpellmaker wants to merge 1 commit intomasterfrom
Open
fix: adds parent config sections if not existing#31ElvenSpellmaker wants to merge 1 commit intomasterfrom
ElvenSpellmaker wants to merge 1 commit intomasterfrom
Conversation
* fix: Adds parent config sections to the ini struct if they don't exist. Fixes #30. * Allows overriding the browser using ROD_BROWSER_WS_URL environment variable, this allows you to run tests in environments with shared networking but no browser or display server running, such as in WSL.
ElvenSpellmaker
force-pushed
the
fix/missing-config-sections
branch
from
e8b653d to
537a53a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: [PR](fix: adds parent config sections if not existing)
Describe the PR
[config]in INI config causes a crash #30.Screenshots
Additional context