Skip to content

fix: standardize error handling in follow route #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pari7maheshwari wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −6
Open

fix: standardize error handling in follow route #205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions apps/backend/src/routes/follow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { FastifyInstance, FastifyRequest, FastifyReply } from 'fastify';
import { decrypt } from '../utils/encryption.js';
import { getErrorMessage } from '../utils/error.util.js';

export async function followRoutes(app: FastifyInstance) {
app.addHook('preHandler', app.authenticate);
Expand Down Expand Up @@ -31,7 +32,7 @@ export async function followRoutes(app: FastifyInstance) {
// Decrypt the stored token
const accessToken = decrypt(oauthToken.accessToken);

try {
try {
let result;
let succeeded = false;

Expand All @@ -56,12 +57,12 @@ try {
status: 'success',
layer: 'api',
},
}).catch(err => app.log.error('Failed to log follow:', err));
}).catch((err: unknown) => app.log.error(`Failed to log follow: ${getErrorMessage(err)}`));
}

return result.response;
} catch (err: any) {
app.log.error(`Follow error for ${platform}:`, err);
} catch (err: unknown) {
app.log.error(`Follow error for ${platform}: ${getErrorMessage(err)}`);

app.prisma.followLog.create({
data: {
Expand All @@ -71,9 +72,12 @@ try {
status: 'error',
layer: 'api',
},
}).catch(e => app.log.error('Failed to log follow error:', e));
}).catch((e: unknown) => app.log.error(`Failed to log follow error: ${getErrorMessage(e)}`));

return reply.status(500).send({ error: 'Follow action failed', message: err.message });
return reply.status(500).send({
error: 'Follow action failed',
message: getErrorMessage(err),
});
}
});
}
Expand Down