Skip to content

fix(auth): encrypt OAuth tokens using encryption utility directly #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Harxhit merged 3 commits into from
May 21, 2026
+14 −0
Merged

fix(auth): encrypt OAuth tokens using encryption utility directly #144

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2c3273
fix(auth): encrypt OAuth tokens using encryption utility directly
Ridanshi May 18, 2026
1234be4
Merge branch 'main' into fix/oauth-token-encryption
ShantKhatri May 21, 2026
b962d5f
fix(auth): isolate OAuth token persistence with focused try/catch
Ridanshi May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions apps/backend/src/routes/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { FastifyInstance, FastifyRequest, FastifyReply } from 'fastify';
import { randomBytes } from 'crypto';
import { encrypt } from '../utils/encryption.js';

const GITHUB_AUTH_URL = 'https://github.com/login/oauth/authorize';
const GITHUB_TOKEN_URL = 'https://github.com/login/oauth/access_token';
Expand Down Expand Up @@ -119,6 +120,19 @@ export async function authRoutes(app: FastifyInstance) {
},
});

// Save the authentication token for 'user:email read:user' so we have a basic platform connection.
// Failure here is non-fatal — the user can still authenticate; the token can be reconnected later.
try {
const encryptedToken = encrypt(tokenData.access_token);
await app.prisma.oAuthToken.upsert({
where: { userId_platform: { userId: user.id, platform: 'github' } },
update: { accessToken: encryptedToken, scopes: 'read:user user:email' },
create: { userId: user.id, platform: 'github', accessToken: encryptedToken, scopes: 'read:user user:email' },
});
} catch (err) {
app.log.error({ err, userId: user.id }, 'Failed to persist GitHub OAuth token — authentication proceeds');
}

// Generate JWT
const token = app.jwt.sign(
{ id: user.id, username: user.username },
Expand Down