Skip to content

Fix #14623: Add created and updated date filters to ApiRiskAcceptance…#14754

Open
NasorHidar wants to merge 1 commit intoDefectDojo:devfrom
NasorHidar:fix-14623-risk-acceptance-filters
Open

Fix #14623: Add created and updated date filters to ApiRiskAcceptance…#14754
NasorHidar wants to merge 1 commit intoDefectDojo:devfrom
NasorHidar:fix-14623-risk-acceptance-filters

Conversation

@NasorHidar
Copy link
Copy Markdown

Description

This PR resolves Issue #14623.

The risk_acceptance API endpoint previously returned created and updated timestamps but lacked the filter query parameters needed by API consumers. This update modifies the ApiRiskAcceptanceFilter class inside dojo/filters.py to include DateRangeFilter logic for both fields, ensuring they support standard DRF date/time lookups (exact, gt, lt, gte, lte), mirroring the setup used in the findings filtersets.

Test results

Verified the django-filter syntax and dictionary mappings align with existing core model implementations in dojo/filters.py. No existing tests were modified.

@dryrunsecurity
Copy link
Copy Markdown

dryrunsecurity Bot commented Apr 26, 2026

DryRun Security

This pull request includes a sensitive edit to dojo/filters.py detected by the configured codepaths analyzer; the scanner flags it as an error (risk threshold: failing) and notes sensitive file paths and allowed authors can be set in .dryrunsecurity.yaml. The finding is not marked blocking but should be reviewed carefully.

🔴 Configured Codepaths Edit in dojo/filters.py (drs_358dcd66)
Vulnerability Configured Codepaths Edit
Description Sensitive edits detected for this file. Sensitive file paths and allowed authors can be configured in .dryrunsecurity.yaml.

We've notified @mtesauro.


Comment to provide feedback on these findings.

Report false positive: @dryrunsecurity fp [FINDING ID] [FEEDBACK]
Report low-impact: @dryrunsecurity nit [FINDING ID] [FEEDBACK]

Example: @dryrunsecurity fp drs_90eda195 This code is not user-facing

All finding details can be found in the DryRun Security Dashboard.

@valentijnscholten
Copy link
Copy Markdown
Member

Could you please rebase against bugfix or dev

@NasorHidar NasorHidar changed the base branch from master to dev April 27, 2026 01:00
@NasorHidar
Copy link
Copy Markdown
Author

Done! Switched the base branch to dev and rebased.

@NasorHidar NasorHidar force-pushed the fix-14623-risk-acceptance-filters branch from 7073a63 to 0491c3a Compare April 27, 2026 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants