Fix setImage latency in mobile-fitting-room: resize garment images to max 1024px#12
Open
tomershlasky wants to merge 1 commit intomainfrom
Open
Fix setImage latency in mobile-fitting-room: resize garment images to max 1024px#12tomershlasky wants to merge 1 commit intomainfrom
tomershlasky wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mobile-fitting-roomexample was callingsetImagewith the full-resolution blob fromurlToImageBlob, whilefull-featuredandoutfit-builderboth pipe throughresizeImageBlob(blob, 1024)first. High-res garment images (e.g. 2000–4000px from fashion sites) cause significant switch latency.resizeImageBlobcall inapplyProductand in theenterFitRoominitial image path.setImageand note that oversized images increase switch latency.Root cause
Customer (SwapCommerce) reported ~6s delays switching outfits via
set_image. Their example images were 530KB–1.5MB. Themobile-fitting-roomexample had the same bug: no image resize beforesetImage, unlike the other examples.Requested by Jake Rothman in Slack (#swapcommerce--decart)
Generated by Claude Code