fallback to jobGroupid if jobrunid=taskrunid#11199
Draft
aboitreaud wants to merge 2 commits intomasterfrom
Draft
fallback to jobGroupid if jobrunid=taskrunid#11199aboitreaud wants to merge 2 commits intomasterfrom
aboitreaud wants to merge 2 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~745b96053c, baseline=1.62.0-SNAPSHOT~4a446d1347
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059335
Total [baseline] (8.833 s) : 0, 8833096
Agent [candidate] (1.059 s) : 0, 1058650
Total [candidate] (8.856 s) : 0, 8856001
section iast
Agent [baseline] (1.24 s) : 0, 1239557
Total [baseline] (9.544 s) : 0, 9544224
Agent [candidate] (1.235 s) : 0, 1234929
Total [candidate] (9.57 s) : 0, 9569867
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~745b96053c, baseline=1.62.0-SNAPSHOT~4a446d1347
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.244 ms) : 0, 1244
crashtracking [candidate] (1.234 ms) : 0, 1234
BytebuddyAgent [baseline] (636.879 ms) : 0, 636879
BytebuddyAgent [candidate] (636.04 ms) : 0, 636040
AgentMeter [baseline] (29.491 ms) : 0, 29491
AgentMeter [candidate] (29.426 ms) : 0, 29426
GlobalTracer [baseline] (249.365 ms) : 0, 249365
GlobalTracer [candidate] (249.305 ms) : 0, 249305
AppSec [baseline] (32.398 ms) : 0, 32398
AppSec [candidate] (32.378 ms) : 0, 32378
Debugger [baseline] (59.912 ms) : 0, 59912
Debugger [candidate] (59.528 ms) : 0, 59528
Remote Config [baseline] (596.809 µs) : 0, 597
Remote Config [candidate] (614.493 µs) : 0, 614
Telemetry [baseline] (9.605 ms) : 0, 9605
Telemetry [candidate] (9.61 ms) : 0, 9610
Flare Poller [baseline] (3.616 ms) : 0, 3616
Flare Poller [candidate] (4.321 ms) : 0, 4321
section iast
crashtracking [baseline] (1.236 ms) : 0, 1236
crashtracking [candidate] (1.237 ms) : 0, 1237
BytebuddyAgent [baseline] (813.702 ms) : 0, 813702
BytebuddyAgent [candidate] (811.513 ms) : 0, 811513
AgentMeter [baseline] (11.499 ms) : 0, 11499
AgentMeter [candidate] (11.374 ms) : 0, 11374
GlobalTracer [baseline] (241.123 ms) : 0, 241123
GlobalTracer [candidate] (239.755 ms) : 0, 239755
IAST [baseline] (27.776 ms) : 0, 27776
IAST [candidate] (29.406 ms) : 0, 29406
AppSec [baseline] (29.975 ms) : 0, 29975
AppSec [candidate] (27.588 ms) : 0, 27588
Debugger [baseline] (65.907 ms) : 0, 65907
Debugger [candidate] (66.025 ms) : 0, 66025
Remote Config [baseline] (538.578 µs) : 0, 539
Remote Config [candidate] (540.709 µs) : 0, 541
Telemetry [baseline] (7.925 ms) : 0, 7925
Telemetry [candidate] (7.818 ms) : 0, 7818
Flare Poller [baseline] (3.536 ms) : 0, 3536
Flare Poller [candidate] (3.494 ms) : 0, 3494
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~745b96053c, baseline=1.62.0-SNAPSHOT~4a446d1347
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064810
Total [baseline] (11.071 s) : 0, 11071454
Agent [candidate] (1.061 s) : 0, 1061335
Total [candidate] (11.15 s) : 0, 11149854
section appsec
Agent [baseline] (1.274 s) : 0, 1274047
Total [baseline] (11.113 s) : 0, 11113384
Agent [candidate] (1.272 s) : 0, 1272216
Total [candidate] (11.079 s) : 0, 11078678
section iast
Agent [baseline] (1.236 s) : 0, 1236067
Total [baseline] (11.365 s) : 0, 11365160
Agent [candidate] (1.251 s) : 0, 1250519
Total [candidate] (11.337 s) : 0, 11337297
section profiling
Agent [baseline] (1.187 s) : 0, 1187091
Total [baseline] (11.094 s) : 0, 11093872
Agent [candidate] (1.197 s) : 0, 1197152
Total [candidate] (11.087 s) : 0, 11087458
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~745b96053c, baseline=1.62.0-SNAPSHOT~4a446d1347
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.233 ms) : 0, 1233
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (639.21 ms) : 0, 639210
BytebuddyAgent [candidate] (637.507 ms) : 0, 637507
AgentMeter [baseline] (29.701 ms) : 0, 29701
AgentMeter [candidate] (29.573 ms) : 0, 29573
GlobalTracer [baseline] (251.116 ms) : 0, 251116
GlobalTracer [candidate] (249.924 ms) : 0, 249924
AppSec [baseline] (32.53 ms) : 0, 32530
AppSec [candidate] (32.411 ms) : 0, 32411
Debugger [baseline] (60.731 ms) : 0, 60731
Debugger [candidate] (60.665 ms) : 0, 60665
Remote Config [baseline] (604.577 µs) : 0, 605
Remote Config [candidate] (595.211 µs) : 0, 595
Telemetry [baseline] (8.938 ms) : 0, 8938
Telemetry [candidate] (8.043 ms) : 0, 8043
Flare Poller [baseline] (4.453 ms) : 0, 4453
Flare Poller [candidate] (5.103 ms) : 0, 5103
section appsec
crashtracking [baseline] (1.249 ms) : 0, 1249
crashtracking [candidate] (1.232 ms) : 0, 1232
BytebuddyAgent [baseline] (682.8 ms) : 0, 682800
BytebuddyAgent [candidate] (681.424 ms) : 0, 681424
AgentMeter [baseline] (12.395 ms) : 0, 12395
AgentMeter [candidate] (12.287 ms) : 0, 12287
GlobalTracer [baseline] (251.195 ms) : 0, 251195
GlobalTracer [candidate] (250.986 ms) : 0, 250986
AppSec [baseline] (187.004 ms) : 0, 187004
AppSec [candidate] (188.944 ms) : 0, 188944
Debugger [baseline] (66.332 ms) : 0, 66332
Debugger [candidate] (64.552 ms) : 0, 64552
Remote Config [baseline] (591.602 µs) : 0, 592
Remote Config [candidate] (586.647 µs) : 0, 587
Telemetry [baseline] (8.03 ms) : 0, 8030
Telemetry [candidate] (7.94 ms) : 0, 7940
Flare Poller [baseline] (3.479 ms) : 0, 3479
Flare Poller [candidate] (3.448 ms) : 0, 3448
IAST [baseline] (24.328 ms) : 0, 24328
IAST [candidate] (24.416 ms) : 0, 24416
section iast
crashtracking [baseline] (1.229 ms) : 0, 1229
crashtracking [candidate] (1.237 ms) : 0, 1237
BytebuddyAgent [baseline] (811.073 ms) : 0, 811073
BytebuddyAgent [candidate] (821.588 ms) : 0, 821588
AgentMeter [baseline] (11.41 ms) : 0, 11410
AgentMeter [candidate] (11.649 ms) : 0, 11649
GlobalTracer [baseline] (240.473 ms) : 0, 240473
GlobalTracer [candidate] (242.413 ms) : 0, 242413
AppSec [baseline] (28.566 ms) : 0, 28566
AppSec [candidate] (26.208 ms) : 0, 26208
Debugger [baseline] (64.223 ms) : 0, 64223
Debugger [candidate] (69.61 ms) : 0, 69610
Remote Config [baseline] (543.892 µs) : 0, 544
Remote Config [candidate] (557.801 µs) : 0, 558
Telemetry [baseline] (7.867 ms) : 0, 7867
Telemetry [candidate] (7.923 ms) : 0, 7923
Flare Poller [baseline] (3.434 ms) : 0, 3434
Flare Poller [candidate] (3.521 ms) : 0, 3521
IAST [baseline] (31.097 ms) : 0, 31097
IAST [candidate] (29.443 ms) : 0, 29443
section profiling
ProfilingAgent [baseline] (93.802 ms) : 0, 93802
ProfilingAgent [candidate] (93.79 ms) : 0, 93790
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (693.085 ms) : 0, 693085
BytebuddyAgent [candidate] (700.315 ms) : 0, 700315
AgentMeter [baseline] (9.01 ms) : 0, 9010
AgentMeter [candidate] (9.068 ms) : 0, 9068
GlobalTracer [baseline] (207.752 ms) : 0, 207752
GlobalTracer [candidate] (209.285 ms) : 0, 209285
AppSec [baseline] (32.601 ms) : 0, 32601
AppSec [candidate] (32.969 ms) : 0, 32969
Debugger [baseline] (66.175 ms) : 0, 66175
Debugger [candidate] (66.296 ms) : 0, 66296
Remote Config [baseline] (574.555 µs) : 0, 575
Remote Config [candidate] (576.045 µs) : 0, 576
Telemetry [baseline] (7.766 ms) : 0, 7766
Telemetry [candidate] (7.827 ms) : 0, 7827
Flare Poller [baseline] (3.524 ms) : 0, 3524
Flare Poller [candidate] (3.458 ms) : 0, 3458
Profiling [baseline] (94.366 ms) : 0, 94366
Profiling [candidate] (94.353 ms) : 0, 94353
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~745b96053c, baseline=1.62.0-SNAPSHOT~4a446d1347
dateFormat X
axisFormat %s
section baseline
no_agent (1.277 ms) : 1264, 1290
. : milestone, 1277,
iast (3.42 ms) : 3375, 3466
. : milestone, 3420,
iast_FULL (5.913 ms) : 5854, 5972
. : milestone, 5913,
iast_GLOBAL (3.705 ms) : 3644, 3766
. : milestone, 3705,
profiling (2.159 ms) : 2140, 2178
. : milestone, 2159,
tracing (1.9 ms) : 1883, 1917
. : milestone, 1900,
section candidate
no_agent (1.272 ms) : 1259, 1285
. : milestone, 1272,
iast (3.488 ms) : 3436, 3540
. : milestone, 3488,
iast_FULL (5.923 ms) : 5862, 5983
. : milestone, 5923,
iast_GLOBAL (3.705 ms) : 3637, 3774
. : milestone, 3705,
profiling (2.238 ms) : 2217, 2259
. : milestone, 2238,
tracing (1.911 ms) : 1895, 1927
. : milestone, 1911,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~745b96053c, baseline=1.62.0-SNAPSHOT~4a446d1347
dateFormat X
axisFormat %s
section baseline
no_agent (19.245 ms) : 19048, 19441
. : milestone, 19245,
appsec (18.393 ms) : 18211, 18574
. : milestone, 18393,
code_origins (17.986 ms) : 17804, 18167
. : milestone, 17986,
iast (17.942 ms) : 17762, 18122
. : milestone, 17942,
profiling (18.608 ms) : 18414, 18802
. : milestone, 18608,
tracing (17.75 ms) : 17572, 17928
. : milestone, 17750,
section candidate
no_agent (18.123 ms) : 17939, 18306
. : milestone, 18123,
appsec (18.616 ms) : 18428, 18805
. : milestone, 18616,
code_origins (17.812 ms) : 17635, 17990
. : milestone, 17812,
iast (17.795 ms) : 17619, 17971
. : milestone, 17795,
profiling (18.315 ms) : 18129, 18501
. : milestone, 18315,
tracing (18.329 ms) : 18147, 18511
. : milestone, 18329,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~745b96053c, baseline=1.62.0-SNAPSHOT~4a446d1347
dateFormat X
axisFormat %s
section baseline
no_agent (1.487 ms) : 1476, 1499
. : milestone, 1487,
appsec (3.753 ms) : 3534, 3971
. : milestone, 3753,
iast (2.27 ms) : 2200, 2340
. : milestone, 2270,
iast_GLOBAL (2.315 ms) : 2245, 2385
. : milestone, 2315,
profiling (2.113 ms) : 2057, 2168
. : milestone, 2113,
tracing (2.079 ms) : 2025, 2133
. : milestone, 2079,
section candidate
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (2.535 ms) : 2480, 2590
. : milestone, 2535,
iast (2.27 ms) : 2201, 2340
. : milestone, 2270,
iast_GLOBAL (2.323 ms) : 2253, 2393
. : milestone, 2323,
profiling (2.099 ms) : 2045, 2154
. : milestone, 2099,
tracing (2.08 ms) : 2026, 2134
. : milestone, 2080,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~745b96053c, baseline=1.62.0-SNAPSHOT~4a446d1347
dateFormat X
axisFormat %s
section baseline
no_agent (14.767 s) : 14767000, 14767000
. : milestone, 14767000,
appsec (14.69 s) : 14690000, 14690000
. : milestone, 14690000,
iast (18.619 s) : 18619000, 18619000
. : milestone, 18619000,
iast_GLOBAL (17.692 s) : 17692000, 17692000
. : milestone, 17692000,
profiling (14.889 s) : 14889000, 14889000
. : milestone, 14889000,
tracing (15.132 s) : 15132000, 15132000
. : milestone, 15132000,
section candidate
no_agent (14.907 s) : 14907000, 14907000
. : milestone, 14907000,
appsec (14.716 s) : 14716000, 14716000
. : milestone, 14716000,
iast (18.735 s) : 18735000, 18735000
. : milestone, 18735000,
iast_GLOBAL (18.093 s) : 18093000, 18093000
. : milestone, 18093000,
profiling (15.094 s) : 15094000, 15094000
. : milestone, 15094000,
tracing (14.918 s) : 14918000, 14918000
. : milestone, 14918000,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
On Databricks 18.2,
spark.databricks.job.runIdreturns the job run ID instead of the task run ID. This causesDatabricksParentContextto compute identical trace and span IDs, orphaning Spark spans from their Databricks parent.Fix: skip
spark.databricks.job.runIdwhen it equals the job run ID and fall through tospark.jobGroup.idextraction.Motivation
Broken parent-child relationship between Databricks job/task spans and Spark spans on Databricks 18.2.
Additional Notes
The
spark.databricks.job.runIdproperty semantics changed in Databricks 18.2 — it now returns the job-level run ID rather than the task-level run ID. Prior versions are unaffected.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue