Skip to content

Windrose: Update UserLeaveRegex and UserJoinRegex#1901

Open
KairuByte wants to merge 2 commits into
CubeCoders:mainfrom
KairuByte:main
Open

Windrose: Update UserLeaveRegex and UserJoinRegex#1901
KairuByte wants to merge 2 commits into
CubeCoders:mainfrom
KairuByte:main

Conversation

@KairuByte
Copy link
Copy Markdown
Contributor

@KairuByte KairuByte commented May 10, 2026

More encompassing account disconnection regex which includes ungraceful disconnects (such as client crashes or taskkill -f -im Windrose-Win64-Shipping.exe)

More encompassing account disconnection regex which includes ungraceful disconnects (such as client crashes)
@KairuByte KairuByte changed the title Update UserLeaveRegex for account disconnection [Windrose] Update UserLeaveRegex for account disconnection May 10, 2026
@KairuByte KairuByte changed the title [Windrose] Update UserLeaveRegex for account disconnection Windrose: Update UserLeaveRegex for account disconnection May 10, 2026
@KairuByte KairuByte marked this pull request as draft May 10, 2026 19:18
@KairuByte
Copy link
Copy Markdown
Contributor Author

Cant for the life of me get this to hit on improper disconnects even though the message is identical for both proper and improper. I suspect I may be running into an issue where the edited GenericModule.kvp file isnt being properly honored, but was unable to determine if that was the case in the time I had available. Will look into this further in the near future.

@Greelan
Copy link
Copy Markdown
Collaborator

Greelan commented May 10, 2026

AMP doesn't behave well when the join matches on name and id but the leave only on id

Correct the user join to not improperly log disconnected users who were last in state `ReadyToPlay` before being moved to the disconnected accounts list
@KairuByte KairuByte changed the title Windrose: Update UserLeaveRegex for account disconnection Windrose: Update UserLeaveRegex and UserJoinRegex May 11, 2026
@KairuByte
Copy link
Copy Markdown
Contributor Author

Changed UserJoinRegex to handle a Windrose disconnect edge case. When Windrose disconnects an account it moves the account into the "Disconnected Accounts" list using the state the account was last in. Clean disconnects use state SaidFarewell, but unclean disconnects often leave the account in ReadyToPlay. That causes AMP to log a proper disconnect (MoveAccountToListOfDisconnected) and then immediately treat the same account as connected again (ReadyToPlay in the disconnected list). This change prevents duplicate reconnect handling by accounting for the ReadyToPlay-on-disconnect case.

@KairuByte KairuByte marked this pull request as ready for review May 11, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants