Open
Conversation
fixed formatting so that the required contents of the .env file is clear
fixed formatting of readme
update test files to use correct api endpoints
use podman instead of docker in readme
…dd local integration testing commands too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
get_app_data()routetoapi/routerust:1.70-slim-buster->rust:1.94.0-slim-trixiefordevcade-apienvironmentforWhy
Application did not use the environmental variables stated in the README.md
Tests did not run correctly all throwing 404 errors
Test Plan
Ran tests using
Env Vars
Changed
DOMAINtoALLOWED_ORIGINreplaced
SQL_URIwithPSQL_PORTPSQL_USERPSQL_PASSPSQL_URIDocumentation
added
env.templatecopy paste instructions to README.mdadded testing section and example command to README.md
updated routes doc url because its a simple one line change
Note that this changes the .env file and as such the file for the container running on OKD will need to be updated (if i am correct)
Checklist
Runs, tests fail but this is due to most likely previous PRs making the test code invalid, not something this PR touched
test result: FAILED. 32 passed; 4 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.10s