Let the sprite engine decide file extension#1936
Open
AndersAstrand wants to merge 1 commit intoCompass:masterfrom
AndersAstrand:master
Open
Let the sprite engine decide file extension#1936AndersAstrand wants to merge 1 commit intoCompass:masterfrom AndersAstrand:master
AndersAstrand wants to merge 1 commit intoCompass:masterfrom
AndersAstrand:master
Conversation
Since the sprite engine decides which format to emit, it makes sense to also let it choose which file extension to use so that web servers can serve the file with correct mime type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the sprite engine decides which format to emit, it makes sense
to also let it choose which file extension to use so that web servers
can serve the file with correct mime type.