Prevent to focus DataColumn itself by default#783
Open
9rnsr wants to merge 1 commit intoCommunityToolkit:mainfrom
Open
Prevent to focus DataColumn itself by default#7839rnsr wants to merge 1 commit intoCommunityToolkit:mainfrom
9rnsr wants to merge 1 commit intoCommunityToolkit:mainfrom
Conversation
Member
|
Cool, I see this in the current gallery where there's a ghost tab stop, will just double-check that the ContentSizer is still navigable (though I noticed that it's not working with keyboard for adjusting column size, may be specific to the DataTable as I see this working on the other Sizer scenarios). |
From the design concept, DataColumn control simply provides a space for the header content, so it should not interact with keyboard operations by default. If focusable something is actually needed, DataTable users can place any controls like a button there.
9rnsr
force-pushed
the
ImproveDataTable-2
branch
from
3972b8f to
5bcd7f9
Compare
Contributor
Author
|
@michael-hawker After this PR change, the tab navigation still move the keyboard focus to the ContentSizer, and then Left and right keys can resize the column. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate PR from #781
From the design concept,
DataColumncontrol simply provides a space for the header content, so it should not interact with keyboard operations by default. If focusable something is actually needed,DataTableusers can place any controls like a button there.