Conversation
|
View your CI Pipeline Execution ↗ for commit b474136 ☁️ Nx Cloud last updated this comment at |
|
aresnik11
changed the title
|
|
||
| Gamut depends on packages that ship modern JavaScript from `node_modules`. Jest often skips transpiling `node_modules`, so importing Gamut in tests can surface parse or syntax errors unless your repo opts those dependencies into your test transform. | ||
|
|
||
| If tests only fail after upgrading Gamut or a transitive dependency, compare your Jest and Babel setup with the above and adjust `transformIgnorePatterns` and plugins accordingly. |
There was a problem hiding this comment.
what is above referring to here?
There was a problem hiding this comment.
idk lol, this line was last and i moved it but ill reword
There was a problem hiding this comment.
better? "If tests only fail after upgrading Gamut or a transitive dependency, compare your Jest and Babel setup with Gamut's and adjust transformIgnorePatterns and plugins accordingly."
|
📬 Published Alpha Packages:
|
|
🚀 Styleguide deploy preview ready! Preview URL: https://69fe188b5e9ce41b0b1d537e--gamut-preview.netlify.app |
3 participants
Overview
Pin @formatjs/intl-locale to 5.3.1. Starting in 5.3.2 the library uses static class blocks (modern JS). Any test runner that runs that file through Babel needs either a recent @babel/preset-env setup that transpiles that syntax, or @babel/plugin-transform-class-static-block. So to avoid having every repo using Gamut need to do this, we just pin to 5.3.1 for now.
PR Checklist
Testing Instructions
Don't make me tap the sign.
PR Links and Envs