Conversation
|
View your CI Pipeline Execution ↗ for commit b16d349 ☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3341 +/- ##
==========================================
- Coverage 90.40% 90.29% -0.12%
==========================================
Files 405 384 -21
Lines 6649 6263 -386
Branches 2154 2014 -140
==========================================
- Hits 6011 5655 -356
+ Misses 630 600 -30
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
something was up w/ netlify, PR preview here Preview URL: https://69fb6509ee4c55607c5b94f5--gamut-preview.netlify.app |
| /** | ||
| * Storybook docs chrome (`parameters.docs.theme`) uses `fontBase` for MDX canvas | ||
| * typography. It must match the toolbar-selected Gamut theme’s `fontFamily.base` | ||
| * (see DocsContainer); otherwise e.g. LX Studio shows Skillsoft Text on `body` | ||
| * from Reboot but Apercu inside addon-docs div rules. | ||
| */ | ||
| export function createGamutDocsTheme( | ||
| fontBase: string = gamutTheme.fontFamily.base | ||
| ) { | ||
| return create({ | ||
| base: 'light', | ||
| brandTitle: isLocalhost ? 'Gamut Local' : 'Gamut', | ||
| brandImage: logo, | ||
| brandUrl: '/', | ||
| fontBase, |
There was a problem hiding this comment.
there was a bug with themes with different fonts inheriting Apercu, this fixes that
|
📬 Published Alpha Packages:
|
|
🚀 Styleguide deploy preview ready! Preview URL: https://69fced4d210c3a00ef36f8fe--gamut-preview.netlify.app |
Overview
For LXStudio:
For Percipio theme:
For both:
Font updates (figma link):
accent: “Skillsoft Sans”
base: “Skillsoft Text”
fontWeight:
bold+titleare500,700is still available.PR Checklist
Testing Instructions
Textpage and see the correct 500 font-weight on titles + bold for both Percipio + LXStudio themePR Links and Envs