Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .nx/version-plans/version-plan-1778097455598.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
gamut-styles: major
gamut: major
---

removes deprecated scss mixins and variables
15 changes: 0 additions & 15 deletions packages/gamut-styles/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,7 @@

Base SCSS for Codecademy

## Variables/

This folder houses all shared SCSS style variables.
It also contains a JavaScript file with color variables.

## Core/

This folder contains a base stylesheet for the app.
This should be imported **once** in your application.

## Utils/

This folder contains Sass functions (pure utilities with no stylesheet output values) and mixins (outputs CSS)
to be used as needed both in Gamut and across the Codecademy app.

The `utils.scss` and `core.scss` just import the index files from their respective folders, to make the syntax to import them from elsewhere easier, e.g.:

`@use "~@codecademy/gamut-styles/utils";`
`@use "~@codecademy/gamut-styles/core";`
35 changes: 18 additions & 17 deletions packages/gamut-styles/core/_reboot.scss
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,14 @@ section {

body {
margin: 0; // 1
font-family: $font-family-base;
font-weight: $font-weight-base;
line-height: $line-height-base;
color: $color-body;
font-family: "Apercu", -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto",
"Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue",
sans-serif;
font-weight: normal;
line-height: 1.5;
color: #10162f;
text-align: left; // 3
background-color: $bg-body; // 2
background-color: #ffffff; // 2
}

// Suppress the focus outline on elements that cannot be accessed via keyboard.
Expand Down Expand Up @@ -105,7 +107,7 @@ h4,
h5,
h6 {
margin-top: 0;
margin-bottom: $margin-bottom-headings;
margin-bottom: 1rem;
}
// stylelint-enable selector-list-comma-newline-after

Expand All @@ -115,7 +117,7 @@ h6 {
// bottom margin to use `rem` units instead of `em`.
p {
margin-top: 0;
margin-bottom: $margin-bottom-paragraph;
margin-bottom: 1rem;
}

// Abbreviations
Expand Down Expand Up @@ -155,7 +157,7 @@ ul ol {
}

dt {
font-weight: $font-weight-dt;
font-weight: bold;
}

dd {
Expand All @@ -174,12 +176,12 @@ dfn {
// stylelint-disable font-weight-notation
b,
strong {
font-weight: $font-weight-bold; // Add the correct font weight in Chrome, Edge, and Safari
font-weight: bold; // Add the correct font weight in Chrome, Edge, and Safari
}
// stylelint-enable font-weight-notation

small {
font-size: $font-size-small; // Add the correct font size in all browsers
font-size: 85%; // Add the correct font size in all browsers
}

//
Expand Down Expand Up @@ -207,13 +209,13 @@ sup {
//

a {
color: $color-link;
text-decoration: $decoration-link;
color: #4b35ef;
text-decoration: none;
background-color: transparent; // Remove the gray background on active links in IE 10.
-webkit-text-decoration-skip: objects; // Remove gaps in links underline in iOS 8+ and Safari 8+.

&:hover {
text-decoration: $hover-decoration-link;
text-decoration: underline;
}
}

Expand Down Expand Up @@ -295,9 +297,8 @@ table {
}

caption {
padding-top: $spacer;
padding-bottom: $spacer;
color: $spacer;
padding-top: 1rem;
padding-bottom: 1rem;
text-align: left;
caption-side: bottom;
}
Expand All @@ -315,7 +316,7 @@ th {
label {
// Allow labels to use `margin` for spacing.
display: inline-block;
margin-bottom: $margin-bottom-label;
margin-bottom: 0;
}

// Remove the default `border-radius` that macOS Chrome adds.
Expand Down
36 changes: 0 additions & 36 deletions packages/gamut-styles/core/_typography.scss

This file was deleted.

2 changes: 0 additions & 2 deletions packages/gamut-styles/core/index.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
@forward "../utils";
@forward "reboot";
@forward "fonts";
@forward "typography";
1 change: 0 additions & 1 deletion packages/gamut-styles/utils.scss

This file was deleted.

26 changes: 0 additions & 26 deletions packages/gamut-styles/utils/functions/index.scss

This file was deleted.

5 changes: 0 additions & 5 deletions packages/gamut-styles/utils/index.scss

This file was deleted.

9 changes: 0 additions & 9 deletions packages/gamut-styles/utils/mixins/_font-smoothing.scss

This file was deleted.

4 changes: 0 additions & 4 deletions packages/gamut-styles/utils/mixins/_no-select.scss

This file was deleted.

85 changes: 0 additions & 85 deletions packages/gamut-styles/utils/mixins/_responsive.scss

This file was deleted.

19 changes: 0 additions & 19 deletions packages/gamut-styles/utils/mixins/_shadow.scss

This file was deleted.

37 changes: 0 additions & 37 deletions packages/gamut-styles/utils/mixins/_sr-only.scss

This file was deleted.

6 changes: 0 additions & 6 deletions packages/gamut-styles/utils/mixins/index.scss

This file was deleted.

Loading
Loading