Birmingham | 2026-MAR-SDC | Joy Opachavalit | Sprint 4 | Implement-cowsay#409
Open
enjoy15 wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
Birmingham | 2026-MAR-SDC | Joy Opachavalit | Sprint 4 | Implement-cowsay#409enjoy15 wants to merge 2 commits intoCodeYourFuture:mainfrom
enjoy15 wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
enjoy15
added
📅 Sprint 4
davidlaucw
added
Review in progress
davidlaucw
reviewed
Apr 22, 2026
davidlaucw
left a comment
davidlaucw
left a comment
There was a problem hiding this comment.
It's almost perfect, except for the two tiny points I mentioned. Good job.
| message = " ".join(args.message) | ||
|
|
||
| # Get the animal function dynamically | ||
| animal_function = getattr(cowsay, args.animal, cowsay.cow) |
There was a problem hiding this comment.
Do you need to define the default value here again? It was set in line 11.
Also, instead of getattr, you may use cowsay.char_funcs described in the library documentation: https://github.com/VaasuDevanS/cowsay-python/tree/main#more-characters
Author
There was a problem hiding this comment.
Replaced getattr(...) with cowsay.char_funcs[args.animal].
| animal_function = getattr(cowsay, args.animal, cowsay.cow) | ||
|
|
||
| # Print the message using the selected animal | ||
| print(animal_function(message)) |
Author
There was a problem hiding this comment.
Removed the extra print(...) and now call the selected cowsay function directly.
davidlaucw
added
Reviewed
enjoy15
added
Needs Review
|
Excellent 👍 |
davidlaucw
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed all exercises