Conversation
Updated acceptance criteria for webpage structure and layout.
Updated acceptance criteria for webpage layout and articles.
Added recommended practices for code formatting and committing.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| - [ ] All inputs have associated labels. | ||
| - [ ] My Lighthouse Accessibility score is 100. | ||
| - [ ] I require a valid name. I have defined a valid name as a text string of two characters or more. | ||
| - [ ] I require a valid name. I have defined a valid namea as a text string of at least two characters and cannot consist only of spaces. |
There was a problem hiding this comment.
Do we want to dictate this for people? Do we want people to think about this and include it in their PR description?
Right now it reads weirdly to me that we're prompting people "Think about what a valid name is" and then requiring a certain answer (which isn't honestly a great definition, but is an easy one to implement)
There was a problem hiding this comment.
I updated the "Task" section by replacing "Think about what a valid name is" by the requirement "Valid name must contain at least two non-space characters".
There was a problem hiding this comment.
Does anything actually point people at this file? I suspect they are unlikely to happen upon it by chance...
There was a problem hiding this comment.
I added the link to this guide in the "Resources" section in the README.md file of each exercise.
| @@ -0,0 +1,58 @@ | |||
| ## Clean Code and Smart Commits: A Practical Guide | |||
|
|
|||
| ### 1. Formatting code consistently | |||
There was a problem hiding this comment.
Do we want to add any requirements about formatting to the problem requirements? Or just leave this as a suggestion?
There was a problem hiding this comment.
I now added a "Adhere to Professional Standards" category in the Acceptance Criteria, and included these checklist items:
- My HTML code has no errors or warnings when validated using https://validator.w3.org/
- My code is consistently formatted
- My page content is free of typos and grammatical mistakes
- I commit often and push regularly to GitHub
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Updated section headers for clarity and consistency.
Added a checklist for developers to ensure code quality and adherence to standards.
|
@illicitonion I have made some changes based on your comments. |
2 participants
Changelist