LONDON | 25-SDC-Nov | Zohreh Kazemianpour | Sprint 1 | Analyse and Refactor Functions#97
LONDON | 25-SDC-Nov | Zohreh Kazemianpour | Sprint 1 | Analyse and Refactor Functions#97zohrehKazemianpour wants to merge 5 commits intoCodeYourFuture:mainfrom
Conversation
…des() loop to a Set-based
… Set based approach
zohrehKazemianpour
added
the
Needs Review
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
The refactored code and the analyses of the refactored code look good!
(1) Can you also show the time complexity of the original implementation?
I think "Time Complexity" here refers to the time complexity of the original implementation, and "Optimal Time Complexity" refers to the time complexity of the refactored version.
(2) Can you improve the indentation of the code in all the source files?
cjyuan
added
Reviewed
Thank you @cjyuan, for reviewing my PR and sorry for the late response, as I took a break from the coursework for a while due to some personal issues. I have made the changes based on your advice. I’d appreciate it if you could review this again when you have a moment. |
zohrehKazemianpour
added
the
Needs Review
|
Spot on analysis. Well done. |
cjyuan
added
Complete
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
2 similar comments
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
2 participants
Self checklist