Merged
Conversation
Generated via Full Stack Developer by HabeSoftware
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #257.
Removes the unreachable
req.bodyfallback in the delete controller and tightens the surrounding error handling.Changes
controllers/delete.jsJSON.parse(JSON.stringify(req.body))round-trip andparseDocumentID(...)chain that pulled@id/idfrom the request body. DELETE requests cannot carry a body (XHR limitation, also called out in the prior comments), and the route already requires:_id, so this branch was dead code.try/catcharound the ID extraction with an explicit early return: whenreq.params._idis missing (theDELETE /v1/api/delete/route case), respond400with a clear message instead of relying on incidental JSON-parse failure.newIDandisValidIDimports fromdatabase/index.js.parseDocumentIDremains imported —healHistoryTreestill uses it.Before
After
Verification
Manually exercised against a local pm2 cluster:
DELETE /v1/api/delete(no id)DELETE /v1/api/delete/(trailing slash)POST /v1/api/createthenDELETE /v1/api/delete/:_idDELETEsame id againDELETEnon-existent idDELETEwithoutAuthorizationThe existing happy-path test in
routes/__tests__/delete.test.jscontinues to apply. No behavioral change to the 204/403/404/401 paths.