[Paintroid-515] Use Paintroid keys for translations#161
Open
Knist1704 wants to merge 2 commits into
Open
Conversation
Lenkomotive
requested changes
May 19, 2026
Contributor
Lenkomotive
left a comment
Lenkomotive
left a comment
There was a problem hiding this comment.
solid work 👍🏼 pls also fix conflicts
| import 'package:intl/intl.dart' as intl; | ||
| import 'app_localizations.dart'; | ||
|
|
||
| // ignore_for_file: type=lint |
Contributor
There was a problem hiding this comment.
can this be removed if we convert the keys to camelCase: pocketpaint_app_name -> pocketpaintAppName? snake_case is not flutter/dart convention
| String get dialog_smoothing => 'Glättung'; | ||
|
|
||
| @override | ||
| String get dialog_zoom_window_enabled => 'Enabled'; |
Contributor
There was a problem hiding this comment.
Some keys are still english, pls check.
| findsOneWidget); | ||
|
|
||
| final okButton = find.widgetWithText(TextButton, 'OK'); | ||
| final okButton = find.widgetWithText(TextButton, 'DONE'); |
Contributor
There was a problem hiding this comment.
Some tests still use hardcoded values, pls check the testfiles again for incosistencies.
| @@ -0,0 +1,6 @@ | |||
| arb-dir: assets/lang | |||
| template-arb-file: app_translations_en.arb | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Add nullable-getter: false and strip the ! from every callsite. dart analyze lists 30 unnecessary_non_null_assertion warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactores the app to use localization keys similar to the ones used in the Paintroid-Kotlin project.
Jira Link
New Features and Enhancements
Refactorings and Bug Fixes
Checklist
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.