Skip to content

Fix check_app_name.sh: resolve FIXMEs and TODOs from #2118#3126

Open
Geet42 wants to merge 1 commit into
CatimaLoyalty:mainfrom
Geet42:fix/check-app-name-script
Open

Fix check_app_name.sh: resolve FIXMEs and TODOs from #2118#3126
Geet42 wants to merge 1 commit into
CatimaLoyalty:mainfrom
Geet42:fix/check-app-name-script

Conversation

@Geet42
Copy link
Copy Markdown

@Geet42 Geet42 commented May 11, 2026

Fixes #2118

  • Replaced global-variable-dependent check() function with per-pass inline logic
  • Added cross-check between title.txt and strings.xml app_name per language
  • Fixed subtitle stripping to handle em dash (—) and en dash (–) variants used in some title.txt files
  • Added warning for strings that hardcode 'Catima' instead of using @string/app_name
  • Fixed comma bug in ALLOWLIST array ("peo," -> "peo")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write CI to protect app_name

1 participant