Add a barcode home screen widget for displaying a selected loyalty card's barcode and with proper orientation handling.#3125
Open
JorySeverijnse wants to merge 3 commits into
Open
Conversation
Member
Please drop that commit from your change. It turns a single-feature PR into a 3000 line change, way too much to review properly. |
Member
|
I'm not opposed to introducing some style lint, but that should really be its own unique change. |
Author
|
Alright, removed the linting. Also, do you have a suggestion as to what preview icon to use? We are now just using the same one that is being used for the Card list widget @drawable/widget_preview |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full implementation of the #737 issue. Have tested it out on my android 16 (pixel 9a) for which it works perfectly
Add barcode widget for displaying loyalty card barcodes on home screen
Refactor barcode generation to use fixed dimensions and add optional format display setting
Fix widget resize handling and correct inverted format toggle behavior
Apply ktlint formatting to entire codebase