Skip to content

fix: adds mutex lock on broadcast #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
astronomerdave merged 1 commit into from
May 19, 2026
+2 −0
Merged

fix: adds mutex lock on broadcast #433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions common/common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ namespace Common {
private:
zmqpp::context &_context;
zmqpp::socket _socket;
mutable std::mutex _publish_mtx;
Mode _mode; ///< publisher or subscriber?
std::string _topic; ///< publisher topic
std::vector<std::string> _topics; ///< list of subscriber topics
Expand Down Expand Up @@ -179,6 +180,7 @@ namespace Common {
if ( _mode != Mode::PUB ) {
throw std::runtime_error( "(Common::PubSub::publish) not a publisher" );
}
std::lock_guard<std::mutex> lock( _publish_mtx );
zmqpp::message message_zmq;
// Publish to either class default _topic or topic specified as
// optional arg.
Expand Down
Loading