Ability to generate a CAL target list#417
Open
prkrtg wants to merge 2 commits into
Open
Conversation
| if xbin <= 0 or ybin <= 0: | ||
| raise ValueError("binning values must be greater than 0.") | ||
|
|
||
| # Nominal exposure times, seconds. |
Contributor
There was a problem hiding this comment.
Could these be in a config file? They may never need to be updated for years or maybe never, but if they ever do need to be updated, it will take a developer to modify the code.
| if n_etalon > 0: | ||
| rows.append( | ||
| _cal_row( | ||
| "CAL_ETALON", |
Contributor
There was a problem hiding this comment.
This will be rejected by the sequencer because there is no calibration target named CAL_ETALON. That suggests we should be getting names from the same place.
prkrtg
force-pushed
the
pgupta/calib_update
branch
from
ff5488c to
792380c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts Matt's bash code to a python function which generates a CSV target list
User clicks on Calibration button to create the target list, and then can use it to run calibrations