FIREFLY-1981: Update Standalone Firefly app's Landing Page#1959
Open
jaladh-singhal wants to merge 16 commits into
Open
FIREFLY-1981: Update Standalone Firefly app's Landing Page#1959jaladh-singhal wants to merge 16 commits into
jaladh-singhal wants to merge 16 commits into
Conversation
jaladh-singhal
added
enhancement
UI
robyww
approved these changes
May 12, 2026
Contributor
robyww
left a comment
robyww
left a comment
There was a problem hiding this comment.
Looks very, very good.
- I think we need to link the sponsering orgaizations.
- We probably need to add a link the the firelfy github page.
- The stand alone work has made the think about how we need to redo the github page.
- Did some resize checks: looks nice
- Overall the color look very good.
- I really like all the examples. Ask the scientist to give you specifics
Comment on lines
+26
to
+31
| * ┌─ bgContainer (Box) ──────────────────────────────────────┐ | ||
| * │ ┌─ contentSection (Stack) ───────────────────────────┐ │ | ||
| * │ │ topSection → DefaultAppBranding (title/desc) │ │ | ||
| * │ │ bottomSection → EmptyResults (actions) │ │ | ||
| * │ └────────────────────────────────────────────────────┘ │ | ||
| * └──────────────────────────────────────────────────────────┘ |
Comment on lines
+23
to
+27
| '✦ FITS/HiPS Images', | ||
| '⊕ DS9/MOC Overlays', | ||
| '⋮⋮ Catalogs at Scale', | ||
| '⇄ Interlinked Views', | ||
| '∿ Spectra & Charts', |
Contributor
There was a problem hiding this comment.
using the utf-8 symbols is really interesting
| onClick: () => dispatchShowDialog(SIDE_BAR_ID), | ||
| }, | ||
| { | ||
| icon: <UploadFile sx={{fontSize: '1.625rem'}}/>, |
Contributor
There was a problem hiding this comment.
all the icon are well used, they look really good.
|
|
||
| const DEFAULT_TITLE = 'Firefly'; | ||
| const DEFAULT_TAGLINE = 'Discover and Explore Astronomy Data — across missions and archives'; | ||
| const DEFAULT_TRUST_LINE = 'Developed by Caltech/IPAC for NASA and NSF'; |
Contributor
There was a problem hiding this comment.
you make need to make links for IPAC, NASA, NFS, probably need to include IRSA as well. LIke the about dialog. Probably needs to be prettier links though.
Member
Author
There was a problem hiding this comment.
Yes I was thinking we may want to do that.
…in LandingPage's DOM tree
jaladh-singhal
commented
May 22, 2026
| "@emotion/react": "^11.11", | ||
| "@emotion/styled": "^11.11", | ||
| "@fontsource/inter": "^5.0", | ||
| "@mui/base": "^5.0.0-beta.22", |
Member
Author
There was a problem hiding this comment.
@mui/base is a transitive dependency that several joy ui components use underneath. I just added it explicitly here because linter was complaining when using Popper component from it for app hints. Note how yarn.lock is unaffected so it's adding nothing new to our JS bundle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes FIREFLY-1981
StandaloneFireflyLandingwhich is analogous to how we doHydraLanding(for SPHEREx and Euclid BGImage)Testing
https://fireflydev.ipac.caltech.edu/firefly-1981-redesign-firefly-landing/firefly
Everything in the glass-effect overlay card is clickable. Click the 3 action cards and example query chips.