Add support for ASUS ROG Falchion RX Low Profile keyboard#84
Open
infiniV wants to merge 1 commit intoCalcProgrammer1:masterfrom
Open
Add support for ASUS ROG Falchion RX Low Profile keyboard#84infiniV wants to merge 1 commit intoCalcProgrammer1:masterfrom
infiniV wants to merge 1 commit intoCalcProgrammer1:masterfrom
Conversation
Adds detection for the wired (PID 0x1B04) variant on AsusAuraTUFKeyboardController with a 68-key ANSI layout map verified by per-lamp probing on real hardware. The visual key grid is identical to the original ROG Falchion's ANSI layout so the existing matrix is reused. The firmware allocates 8 slots per column with the right-cluster keys at lamp indices 82..117, above the 82-lamp count advertised by the LampArray descriptor. Closes #4203
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4203.
Wired Falchion RX Low Profile, USB PID
0x1B04. The vendor protocol isthe same as the original Falchion (interface 1, usage page 0xFF00), so
this only adds the PID and a layout map with this keyboard's lamp
indices. No controller code changed.
Key grid is the same as the original Falchion ANSI, so
ASUS_FALCHION_LAYOUT_KEYS_ANSIis reused. Lamp indices followcol*8+row+1. The right-cluster keys land at indices 82..117, which isabove the 82-lamp count that LampArray advertises. Probed on hardware,
bcdDevice 5.11.
The 2.4GHz OMNI Receiver (
0x1ACE) isn't here. Different vendorchannel (iface 2, usage page 0xFF02), needs its own work. BT mode
(
0x1B08) doesn't expose an RGB channel.