Util cleanup by kyanvde · Pull Request #84 · BuildTheEarth/BuildTeamTools

kyanvde · 2026-04-28T21:55:08Z

This pull request aims to clean up the old code under /utils a bit.
Main changes:

Switch to using https://github.com/BuildTheEarth/projection for projection based conversion instead of keeping a duplicate of the t-- code inside of our source code.
Rewrite of the head code to make it cleaner
Removal of lots of unused code

github-actions · 2026-04-28T22:00:03Z

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

Copilot

Pull request overview

Cleans up /utils by removing legacy/unused utility code, migrating custom head creation to a new HeadFactory API, and switching geo/projection conversions to the external net.buildtheearth:projection library.

Changes:

Remove legacy raycast, JSON, geo/projection, constants/errors, and custom-head utilities.
Introduce utils.heads (HeadFactory, HeadTexture, HeadColor, LetterType) and update menus/models to use it.
Replace internal coordinate conversion/projection stack with net.buildtheearth:projection:1.0.3 and new helpers in NavUtils / BuildTeamTools#getEarthWorld().

Reviewed changes

Copilot reviewed 46 out of 47 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/main/java/net/buildtheearth/buildteamtools/utils/raycast/RaycastAPIMath.java	Removes legacy raycast math utility.
src/main/java/net/buildtheearth/buildteamtools/utils/raycast/Raycast.java	Removes legacy raycast implementation.
src/main/java/net/buildtheearth/buildteamtools/utils/menus/NameListMenu.java	Switches “Next” item to `HeadFactory` checkmark head.
src/main/java/net/buildtheearth/buildteamtools/utils/menus/BlockListMenu.java	Switches “Next” item to `HeadFactory` checkmark head.
src/main/java/net/buildtheearth/buildteamtools/utils/menus/AbstractPaginatedMenu.java	Reworks pagination UI items to use `HeadFactory`.
src/main/java/net/buildtheearth/buildteamtools/utils/menus/AbstractMenu.java	Migrates counters/choice items/back item to `HeadFactory`/`HeadColor`.
src/main/java/net/buildtheearth/buildteamtools/utils/io/Errors.java	Removes centralized error-string constants.
src/main/java/net/buildtheearth/buildteamtools/utils/io/Constants.java	Removes centralized constants (API url, default key, etc.).
src/main/java/net/buildtheearth/buildteamtools/utils/heads/LetterType.java	Adds letter-style enum for head generation.
src/main/java/net/buildtheearth/buildteamtools/utils/heads/HeadTexture.java	Adds centralized base64 texture enum for heads.
src/main/java/net/buildtheearth/buildteamtools/utils/heads/HeadFactory.java	Adds new factory for generating textured heads (numbers/letters/counters).
src/main/java/net/buildtheearth/buildteamtools/utils/heads/HeadColor.java	Adds color enum to support colorized head variants.
src/main/java/net/buildtheearth/buildteamtools/utils/geo/projection/airocean/ModifiedAirocean.java	Removes internal modified Airocean projection code.
src/main/java/net/buildtheearth/buildteamtools/utils/geo/projection/airocean/ConformalEstimate.java	Removes internal conformal projection implementation.
src/main/java/net/buildtheearth/buildteamtools/utils/geo/projection/airocean/Airocean.java	Removes internal Airocean projection implementation.
src/main/java/net/buildtheearth/buildteamtools/utils/geo/projection/UprightOrientationProjectionTransform.java	Removes internal projection transform utility.
src/main/java/net/buildtheearth/buildteamtools/utils/geo/projection/ScaleProjectionTransform.java	Removes internal projection scaling transform.
src/main/java/net/buildtheearth/buildteamtools/utils/geo/projection/ProjectionTransform.java	Removes internal base transform type.
src/main/java/net/buildtheearth/buildteamtools/utils/geo/projection/OutOfProjectionBoundsException.java	Removes internal projection bounds exception type.
src/main/java/net/buildtheearth/buildteamtools/utils/geo/projection/OffsetProjectionTransform.java	Removes internal projection offset transform.
src/main/java/net/buildtheearth/buildteamtools/utils/geo/projection/InvertableVectorField.java	Removes internal vector-field inversion utility.
src/main/java/net/buildtheearth/buildteamtools/utils/geo/projection/GeographicProjection.java	Removes internal projection registry/abstraction.
src/main/java/net/buildtheearth/buildteamtools/utils/geo/CoordinateConversion.java	Removes internal Minecraft↔geo conversion helper.
src/main/java/net/buildtheearth/buildteamtools/utils/MathUtils.java	Removes internal math helpers used by old projection code.
src/main/java/net/buildtheearth/buildteamtools/utils/JsonUtils.java	Removes JSON parsing utility.
src/main/java/net/buildtheearth/buildteamtools/utils/GeometricUtils.java	Removes old geo→Bukkit `Location` helpers (replaced by `NavUtils`).
src/main/java/net/buildtheearth/buildteamtools/utils/CustomHeads.java	Removes legacy custom head constants/helpers (replaced by `HeadFactory`).
src/main/java/net/buildtheearth/buildteamtools/utils/Config.java	Minor formatting cleanup.
src/main/java/net/buildtheearth/buildteamtools/modules/stats/menu/StatsMenu.java	Migrates menu icons to `HeadFactory` textures.
src/main/java/net/buildtheearth/buildteamtools/modules/network/NetworkModule.java	Inlines removed constants/errors and keeps API-key validation.
src/main/java/net/buildtheearth/buildteamtools/modules/navigation/components/warps/model/WarpGroup.java	Migrates letter-head fallback to `HeadFactory.letter`.
src/main/java/net/buildtheearth/buildteamtools/modules/navigation/components/warps/model/Warp.java	Migrates letter-head fallback to `HeadFactory.letter`.
src/main/java/net/buildtheearth/buildteamtools/modules/navigation/components/warps/menu/WarpMenu.java	Migrates “create warp” icon to `HeadFactory` green plus.
src/main/java/net/buildtheearth/buildteamtools/modules/navigation/components/warps/menu/WarpGroupMenu.java	Migrates “create warp group” icon to `HeadFactory` green plus.
src/main/java/net/buildtheearth/buildteamtools/modules/navigation/components/warps/menu/WarpGroupEditMenu.java	Migrates confirm + group icon heads to `HeadFactory`.
src/main/java/net/buildtheearth/buildteamtools/modules/navigation/components/warps/menu/WarpEditMenu.java	Migrates confirm/group heads + switches to external projection conversion.
src/main/java/net/buildtheearth/buildteamtools/modules/navigation/components/warps/menu/MaterialSelectionMenu.java	Migrates “custom head” icon to `HeadFactory.letter`.
src/main/java/net/buildtheearth/buildteamtools/modules/navigation/components/warps/WarpsComponent.java	Switches teleport/creation flows to external projection + new NavUtils location helpers.
src/main/java/net/buildtheearth/buildteamtools/modules/navigation/components/tpll/TpllComponent.java	Uses `NavUtils` for geo→location conversion.
src/main/java/net/buildtheearth/buildteamtools/modules/navigation/components/bluemap/BluemapComponent.java	Uses external projection to place BlueMap warp markers.
src/main/java/net/buildtheearth/buildteamtools/modules/navigation/NavUtils.java	Adds geo→Bukkit location helpers based on external projection + earth-world lookup.
src/main/java/net/buildtheearth/buildteamtools/modules/generator/components/road/menu/AdvancedSettingsMenu.java	Migrates counters/next button to `HeadFactory`/`HeadColor`.
src/main/java/net/buildtheearth/buildteamtools/modules/generator/components/kml/KmlCommand.java	Uses `NavUtils` for coordinate→location conversion (doc updated partially).
src/main/java/net/buildtheearth/buildteamtools/modules/generator/components/house/menu/AdvancedSettingsMenu.java	Migrates counters/next button to `HeadFactory`/`HeadColor`.
src/main/java/net/buildtheearth/buildteamtools/BuildTeamTools.java	Adds cached `earthWorld` getter based on config.
settings.gradle.kts	Adds BTE Maven repo (now duplicated).
build.gradle.kts	Adds dependency on `net.buildtheearth:projection:1.0.3`.

Comments suppressed due to low confidence (1)

src/main/java/net/buildtheearth/buildteamtools/modules/generator/components/kml/KmlCommand.java:525

This Javadoc is now inconsistent after moving from GeometricUtils to NavUtils: it has an empty <li> (“using

GeometricUtils

NavUtils.getLocationFromCoordinates(...)

     * Converts geographic coordinates (latitude/longitude) to a Minecraft Location.
     * <p>
     * This method:
     * <ol>
     *   <li>Converts lat/lon to Minecraft X/Z using </li>
     *   <li>Applies the KML altitude offset (Google Earth altitudes are relative to ground)</li>
     * </ol>
     * <p>
     * Note: GeometricUtils already adds +2 to terrain elevation, so we don't subtract it here anymore.
     *

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…adTexture

Nudelsuppe42

lgtm, but dont trust me

Co-authored-by: Nudesuppe42 <67996941+Nudelsuppe42@users.noreply.github.com>

kyanvde added 9 commits April 28, 2026 20:31

refactor(src): Start using external library for projection conversions.

3faef5a

refactor(utils): Remove obsolete MathUtils.java

4d139e0

refactor(utils): Move GeometricUtils to other file and clean up code.

d9efa72

refactor(utils): Remove unused JsonUtils.java

45e0a1d

refactor(utils): Refactor head utilities (WIP).

ef92b47

refactor(utils): Remove unused raycasting code.

4436d18

refactor(utils): Introduce HeadFactory.java

2352c8b

refactor(utils): Finish reworking head code.

4bf3af2

refactor(utils): Removed nearly unused Constants.java

4dffd11

refactor(utils): Removed Errors.java because it only contained 2 errors.

0658e38

kyanvde requested review from Nudelsuppe42 and Zoriot April 28, 2026 22:12

Zoriot requested a review from Copilot April 29, 2026 02:58

Copilot started reviewing on behalf of Zoriot April 29, 2026 02:58 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

fix(utils): Fix some small bugs discovered during code review.

57ebaf6

kyanvde self-assigned this Apr 29, 2026

kyanvde added 2 commits April 29, 2026 13:22

fix(utils): Fix colorizedHead incorrectly calculating the required He…

6aefacb

…adTexture

fix(utils): Remove unused imports

c4fa553

Nudelsuppe42 reviewed Apr 29, 2026

View reviewed changes

Comment thread settings.gradle.kts Outdated

Nudelsuppe42 reviewed Apr 29, 2026

View reviewed changes

Update settings.gradle.kts

e506934

Co-authored-by: Nudesuppe42 <67996941+Nudelsuppe42@users.noreply.github.com>

kyanvde requested a review from Jasupa April 30, 2026 07:29

Jasupa approved these changes Apr 30, 2026

View reviewed changes

kyanvde merged commit c087234 into main Apr 30, 2026
4 checks passed

kyanvde deleted the util-cleanup branch April 30, 2026 07:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Util cleanup#84

Util cleanup#84
kyanvde merged 14 commits intomainfrom
util-cleanup

kyanvde commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nudelsuppe42 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

kyanvde commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Qodana for JVM

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nudelsuppe42 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Apr 28, 2026 •

edited

Loading