Skip to content

fix(signaling): inject from_user_id into all relayed WebRTC messages#69

Merged
aniebietafia merged 1 commit into
mainfrom
fixes/production_bugs
May 12, 2026
Merged

fix(signaling): inject from_user_id into all relayed WebRTC messages#69
aniebietafia merged 1 commit into
mainfrom
fixes/production_bugs

Conversation

@aniebietafia
Copy link
Copy Markdown
Contributor

The backend was forwarding raw payloads without adding the sender's identity, causing the frontend to receive offers/answers with from_user_id = undefined. This silently dropped all WebRTC handshakes, preventing media from flowing between participants.

The backend was forwarding raw payloads without adding the sender's
identity, causing the frontend to receive offers/answers with
from_user_id = undefined. This silently dropped all WebRTC handshakes,
preventing media from flowing between participants.

Signed-off-by: aniebietafia <aniebietafia87@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

Warning

Rate limit exceeded

@aniebietafia has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 28 minutes and 56 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4b29742a-51ac-4f0f-952b-862dd19144fb

📥 Commits

Reviewing files that changed from the base of the PR and between df722ea and a67133e.

📒 Files selected for processing (2)
  • app/modules/meeting/ws_router.py
  • tests/meeting/test_ws_router.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fixes/production_bugs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aniebietafia aniebietafia merged commit 52c8107 into main May 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant