#112: post-#111 cleanup — obsolete tests + orphan modules + legacy scripts

[BrettKinny]

Summary

Follow-up cleanup after #113 ripped 5168 lines of dead voice + perception code from bridge.py. Three buckets in three commits:

Bucket 1 — Tests (commit b6f1c40)

tests/test_bridge_routes.py: 35 failing tests targeting ripped endpoints. Kept HealthTests (rewritten for the new minimal {status, service} shape); dropped everything else.

Deleted class	Reason
PerceptionEventStateTests	/api/perception/event + /state ripped
CalendarTodayTests	/api/calendar/today moved to dotty-behaviour (dotty-behaviour/routes/calendar.py)
VoiceMemoryLogTests, VoiceRememberTests, VoiceEscalateTests	voice path ripped
VisionExplainTests, AudioExplainTests	moved to dotty-behaviour
MessageTests, MessageStreamTests	ACP /api/message ripped
PerceptionFeedTests, VisionLatestTests	perception bus moved to dotty-behaviour

Also dropped the now-unused _StubProc / _install_acp_stub / _reset_perception_state helpers and the heavy env-var dance (IDLE_PHOTOGRAPHER_ENABLED, DREAMER_ENABLED, CALENDAR_IDS, ZEROCLAW_BIN, CONVO_LOG_DIR) that the obsolete tests required.

Bucket 2 — Orphan modules (commit 1095559)

Modules + tests that were no longer imported by bridge.py / bridge/dashboard.py after the rip:

bridge/speaker.py            tests/test_speaker.py
bridge/household.py          tests/test_household.py
bridge/proactive_greeter.py  tests/test_proactive_greeter.py
bridge/purr_player.py        tests/test_bridge_dispatch.py
bridge/server_push.py        (no dedicated test)
bridge/perception/           tests/test_perception_cache.py
bridge/sensor_feed.html      (orphan template, not referenced anywhere)

Plus four dead-helper tests that mirrored code ripped from bridge.py itself (not orphan-module tests, but testing nothing real anymore):

tests/test_idle_photographer.py        idle-photographer notability helper
tests/test_bridge_perception_state.py  /api/perception/state staleness helper
tests/test_dream_dance_writers.py      dreamer + dance reflector writers
tests/test_room_view_parser.py         room_view VLM response parser
tests/test_memory_type_tags.py         NDJSON type taxonomy (dream/dance/perception/scene_synthesis)

bridge/security_watch.py is intentionally kept — bridge/dashboard.py imports security_watch.get_recent_cycles for the /ui/security/recent/{device} panel. Verified by grep before final commit.

Bucket 3 — Legacy RPi scripts (commit e778f28)

scripts/deploy-bridge.sh           tar-over-ssh deploy to the retired RPi
scripts/install-bridge.sh          systemd-unit installer
zeroclaw-bridge.service.template   the systemd unit itself

scripts/deploy-bridge-unraid.sh + bridge/Dockerfile (from #109) is the post-#36 replacement.

Also fixed up Makefile — the setup wizard was rendering zeroclaw-bridge.service.template and printing a "Deploy zeroclaw-bridge.service" hint. Both removed. Doc references in CHANGELOG.md and docs/cutover-behaviour.md were left in place per the cleanup brief (historical record); the dotty-deploy-bridge skill description still mentions the old RPi path and is flagged for a follow-up docs sweep.

Stats

Bucket	Tests removed	Files deleted
1	32 (rewrote HealthTests 3→3)	0
2	(8 files of tests)	15 (7 bridge modules/dirs + 8 test files)
3	0	3 + Makefile edit

pytest tests/ -q: 35 failed, 224 passed → 0 failed, 64 passed. (Net test count drops because Bucket 1 removed 32 obsolete cases from one file and Bucket 2 removed 9 entire test files for ripped features.)

Ambiguous items investigated

• HealthTests: brief said KEEP because /health still exists, but the old tests asserted on acp_running / cached_session / session_turns fields that are gone. Rewrote against the new {status, service} shape rather than deleting.
• bridge/security_watch.py: kept (load-bearing for the dashboard, per brief). Confirmed bridge/dashboard.py:2396-2397 does from bridge import security_watch and calls security_watch.get_recent_cycles(limit=10).
• bridge/sensor_feed.html: zero references in any .py or .html under bridge/ or in bridge.py. Deleted.
• Makefile zeroclaw-bridge.service render step: deleting the template without this fix would break make setup. Scope-creep but unavoidable.

Test plan

• pytest tests/ -q — 0 failed, 64 passed (was 35 failed, 224 passed before this branch)
• python -c "import bridge" — clean
• python -c "from bridge.dashboard import *" — clean
• python bridge.py import — clean (warning about ephemeral CSRF secret as expected)
• All hx-get="..." URLs in bridge/templates/*.html resolve to a handler in bridge.py or bridge/dashboard.py (/health + 16 /ui/* routes verified)
• make -n help parses Makefile cleanly after the edit

🤖 Generated with Claude Code