FIXED: Bug where max island progress would decrease when island level should be negative#434
Draft
msmith-codes wants to merge 1 commit into
Draft
FIXED: Bug where max island progress would decrease when island level should be negative#434msmith-codes wants to merge 1 commit into
msmith-codes wants to merge 1 commit into
Conversation
Contributor
Author
|
I'm not getting this build failed error on my local build. I'll take a further look to see if there was any oversight. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the calculation of points accumulated within the current level in the
tidyUp()method ofIslandLevelCalculator.java. The main change is a more robust handling of level-0 islands to prevent negative progress and calculation errors, especially for new islands or when block counts drop below the starting count.Calculation logic improvements:
minBlocks), preventing negative or misleading progress values and avoiding unsafe searches that could result in NaN or incorrect values due to the behavior ofcalculateLevelwith negative inputs.lowerBlocksfor use in the points calculation. [1] [2]results.pointsFromCurrentLevelis updated to useblockAndDeathPoints - lowerBlocks, ensuring correct progress reporting for all cases.