feat(hooks): add CraftEngineHook.getItemId(item) lookup#2973
Merged
Conversation
Mirrors the recently-added getItemStack(id) helper. Lets addon command handlers (e.g. /is value hand in Level addon) recognize a held CraftEngine custom item without depending on CraftEngine directly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4 tasks
|
msmith-codes
pushed a commit
to msmith-codes/Level
that referenced
this pull request
May 12, 2026
Three call sites were missing CraftEngine support, so /is value hand returned "no value" for held CraftEngine items, the value panel showed a paper icon with the prettified namespaced key, and the chat output used the raw key instead of the configured display name: - Level.getCustomBlockId now checks CraftEngineHook.getItemId, so a held custom item is mapped to its namespaced ID. - Utils.getCustomBlockItemStack now delegates to CraftEngineHook.getItemStack so the panel renders the real icon. - Utils.getCustomBlockDisplayName now also reads the modern minecraft:item_name component (hasItemName/getItemName) used by CraftEngine, in addition to the legacy display.Name used by Oraxen, Nexo, and ItemsAdder. - IslandValueCommand.printValue routes string IDs through the same getCustomBlockItemStack/getCustomBlockDisplayName path used by the panel, so the chat message shows the configured display name. Requires BentoBox >= 3.15.1-SNAPSHOT (BentoBoxWorld/BentoBox#2973 for the new getItemId helper). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CraftEngineHook.getItemId(ItemStack)returning the namespaced ID of a held CraftEngine custom item, ornullwhen the item is not a CraftEngine custom item.getItemStack(id)helper (added in 9d3715a) so addons can map both directions without depending on CraftEngine directly.Why
Needed for the Level addon fix to issue BentoBoxWorld/Level#428. The addon's
/is value handcommand and value-panel icon lookup both need to recognize a held CraftEngine item; without this helper they fall back to the vanilla material (PAPER) and report "no value".Test plan
./gradlew compileJavapasses