Fix Dynmap area markers always rendering at y=64#2972
Merged
Conversation
…ght range Agent-Logs-Url: https://github.com/BentoBoxWorld/BentoBox/sessions/dc08b84e-b9de-4e74-9669-11a2a052a6fa Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Dynmap marker area's y value behavior
Fix Dynmap area markers always rendering at y=64
May 9, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Dynmap defaults
ytop/ybottomto 64 whensetRangeYis never called, causing all island area markers to appear at sea level regardless of world height — visually wrong in isometric view.Changes
DynmapHook.setMarker()— callsarea.setRangeY(world.getMaxHeight(), world.getMinHeight())after creating the internal island area marker, spanning the full world height range (e.g. -64 → 320 for the overworld)DynmapHook.addPolygonMarker()— same fix applied to the publicMapHookAPI path; coversaddAreaMarker()since it delegates hereDynmapHookTest— adds world min/max height stubs (-64/320) and three new tests verifyingsetRangeYis called correctly for internal island markers, polygon markers, and area markers