Skip to content

fix: resync magic block to client after entity-spawn cancel #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tastybento merged 1 commit into from
May 3, 2026
Merged

fix: resync magic block to client after entity-spawn cancel #514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/main/java/world/bentobox/aoneblock/listeners/BlockListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,12 +527,18 @@ private void processNextBlock(Cancellable e, Island i, Player player, Block bloc
* @param nextBlock - next block object containing entity info
*/
private void handleEntitySpawn(Cancellable e, Island i, Player player, Block block, OneBlockObject nextBlock) {
if (!(e instanceof EntitySpawnEvent)) {
boolean cancelled = !(e instanceof EntitySpawnEvent);
if (cancelled) {
e.setCancelled(true);
}
spawnEntity(nextBlock, block);
// Cancelling BlockBreakEvent at HIGHEST priority leaves the client with a
// mispredicted "block gone" state; resync the actual block to clear it.
if (cancelled && player != null) {
player.sendBlockChange(block.getLocation(), block.getBlockData());
}
Bukkit.getPluginManager().callEvent(new MagicBlockEntityEvent(i,
player == null ? null : player.getUniqueId(),
player == null ? null : player.getUniqueId(),
block, nextBlock.getEntityType()));
}

Expand Down
Loading