Add VoteStreak migration, recurring option, and legacy progress migration#1508
Closed
Add VoteStreak migration, recurring option, and legacy progress migration#1508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
VoteStreakconfig layout into the newVoteStreaksformat and preserve existing user progress.Recurringoption to allow streaks to either reward every N completions or only once at N.Description
recurringboolean toVoteStreakDefinitionwith constructors updated to preserve default behavior.VoteStreakHandler.processVoteForDefinitionto differentiate recurring rewards (every N completions) from one-time rewards (only at exactly N).StreakStateon first access.migrateLegacyConfigManually()and legacy loaderVoteStreakConfigLoader.loadLegacyto convert oldVoteStreaksections intoVoteStreaks, including creating new definition IDs, moving rewards, and marking legacy entries disabled.MigrateVoteStreaks(shown as/av migratevotestreaksin logs) inCommandLoaderto trigger migration and reload.VoteStreakconfiguration sampleSpecialRewards.ymlto document theRecurringoption and to include the new example field.VoteStreakHandlerTestto cover loading, legacy-state upgrade, and config migration behaviors.Testing
VoteStreakHandlerTestJUnit suite which includes tests for config loading, old-state upgrades, legacy-progress migration, and config migration, and all tests passed.VoteStreaksis missing and suggests running the migration command.Codex Task