Add legacy VoteStreak migration, recurring flag, and admin migrate command#1507
Closed
Add legacy VoteStreak migration, recurring flag, and admin migrate command#1507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
VoteStreakconfig and per-user legacy progress into the newVoteStreaksformat to avoid data loss when upgrading.Description
recurringflag toVoteStreakDefinitionwith a new constructor overload and expose it viaisRecurring()to control reward behavior.VoteStreakHandler.processVoteForDefinitionto reward either once at the interval (recurring=false) or repeatedly every interval (recurring=true).VoteStreakHandler:getLegacyStreakProgress,migrateLegacyProgressIfNeeded, andmigrateLegacyConfigManually, plus legacy-loading logic inVoteStreakConfigLoaderto convertVoteStreak->VoteStreaksentries, create IDs, persist migrated sections, and register user data columns.MigrateVoteStreaks) inCommandLoaderto runmigrateLegacyConfigManually()and reload definitions with an informational message.SpecialRewards.ymlexample to include theRecurringoption and documentation comment for the new behavior.VoteStreakHandlerTestto cover migration of per-user legacy progress and the config-section migration, and adjust helper utilities for the newRecurringproperty and silent logger handling.Testing
VoteStreakHandlerTestwhich now includesprocessVote_migratesLegacyProgressIntoNewStateandconfigLoader_migratesLegacyVoteStreakSectionand all tests passed.mvn test), and the modified vote streak tests completed successfully.Codex Task