Support recurring vote-streak rewards and migrate legacy streak config/state#1506
Closed
Support recurring vote-streak rewards and migrate legacy streak config/state#1506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
VoteStreakconfig section into the newVoteStreaksformat.Description
recurringboolean toVoteStreakDefinitionand updated its constructor and usages to carry the new option.VoteStreakHandler.processVoteForDefinitionto honorrecurring(reward every N completions when true, otherwise reward only once at N).getLegacyStreakProgressandmigrateLegacyProgressIfNeededto import old per-user streak counters into the new serialized streak state on first use.loadLegacyandloadLegacyTypeto ingest the deprecatedVoteStreak->Day|Week|Monthsections, createVoteStreakDefinitionentries, and disable the old config nodes; also addedRecurringsupport to the exampleSpecialRewards.yml.Testing
VoteStreakHandlerTest, includingconfigLoader_loadsDefinition_andGetDefinitionWorks,processVote_whenAlreadyCountedThisPeriod_doesNotIncrementStreakAgain,processVote_acceptsOldFiveFieldFormat_andUpgradesState,processVote_migratesLegacyProgressIntoNewState, andconfigLoader_migratesLegacyVoteStreakSection.Codex Task