Remove MSTest.TestFramework from Core project#3476
Merged
Conversation
Agent-Logs-Url: https://github.com/Azure/data-api-builder/sessions/efe87aa7-2f10-400e-8e95-7fed69530eca Co-authored-by: vadeveka <52937801+vadeveka@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
vadeveka
April 28, 2026 00:25
View session
vadeveka
approved these changes
Apr 28, 2026
vadeveka
requested review from
Alekhya-Polavarapu,
Aniruddh25,
JerryNixon,
RubenCerna2079,
aaronburtle,
anushakolan,
rusamant,
sourabh1007,
souvikghosh04 and
stuartpa
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an unused test-only dependency (MSTest.TestFramework) from the non-test Core project to keep runtime dependencies minimal and correctly scoped.
Changes:
- Removed
MSTest.TestFrameworkPackageReferencefromsrc/Core/Azure.DataApiBuilder.Core.csproj.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Aniruddh25
approved these changes
Apr 28, 2026
2 tasks
RubenCerna2079
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
MSTest.TestFrameworkpackage reference from the Core project (src/Core/Azure.DataApiBuilder.Core.csproj).The Core project is not a test project and should not have any unit test dependencies.
MSTest.TestFrameworkwas never used in any Core source files — it was an unnecessary dependency that should only exist in test projects (Cli.Tests,Service.Tests).Changes
<PackageReference Include="MSTest.TestFramework" />fromsrc/Core/Azure.DataApiBuilder.Core.csproj