test(ci): flake-group new e2e_slashing tests to unblock merge-train/spartan#23356
Draft
AztecBot wants to merge 1 commit into
Draft
test(ci): flake-group new e2e_slashing tests to unblock merge-train/spartan#23356AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #23344 (the
merge-train/spartanrollup) was dequeued from the merge queue twice in a row (2026-05-16 and 2026-05-18), each time after ~19–20 min — the timing signature of a test failing ~10 min into the test phase of amerge-queue-heavygrind, not a build error or timeout.merge-queue-heavymode runs 10 parallelci-full-no-test-cachegrinds + 1 arm64 fast (ci.sh:160), halting on the first failure. The same code passes the PR-timefastCI (single grind). The 10x grind is specifically there to surface flakes the single-grind misses.The merge-train introduced two new test files (
81c026ad42..48be067f5d) underyarn-project/end-to-end/src/e2e_slashing/—attested_invalid_proposal.test.ts(#23184) andbroadcasted_invalid_checkpoint_proposal_slash.test.ts(#23250). Both spin up a fullP2PNetworkTest, use multipleretryUntilblocks withAZTEC_SLOT_DURATION * 3timeouts, and havejest.setTimeout(1_000_000). Neither is covered by the existing flake patterns. The structurally-similare2e_p2p/*ande2e_epochs/*directories are already blanket-grouped undere2e-p2p-epoch-flakes(threshold 5).What
Add a single entry so
src/e2e_slashing/*.test.tsjoins the same flake group:Threshold is shared (5): up to 4 simultaneous flakes are tolerated; a real bug still fails CI.
Caveats
The merge-queue grind log is gated by GitHub admin /
CI_PASSWORD, neither of which I have, so I could not pin the exact failing test fromruns/26013363441. Full analysis and reasoning: https://gist.github.com/AztecBot/568994beba45c83968fed3f4359f8e88./bootstrap.sh ciwas not run locally — full CI requires Docker + EC2 spot orchestration that isn't reachable from this container.ClaudeBox log: https://claudebox.work/s/65034965a86de4ab?run=1