feat(avm)!: Remove is_infinite flag from AVM ECC & update noir submodule with serialization changes#23342
Draft
MirandaWood wants to merge 10 commits into
Draft
feat(avm)!: Remove is_infinite flag from AVM ECC & update noir submodule with serialization changes#23342MirandaWood wants to merge 10 commits into
is_infinite flag from AVM ECC & update noir submodule with serialization changes#23342MirandaWood wants to merge 10 commits into
Conversation
ECAdd no longer takes is_infinite operands. Update the transpiler, inline ECADD handler, and MSM procedure to use the new (x, y) point layout with (0, 0) as the point at infinity.
Regenerate acir.hpp from noir's autogen and propagate the resulting shape changes through the dsl: - ECAdd / MSM no longer carry is_infinite; (0, 0) is now the point at infinity throughout EcAdd, MultiScalarMul, and to_grumpkin_point. - MemOp switches from three Expressions (operation, index, value) to (read: bool, index: Witness, value: Witness). - Circuit drops current_witness_index. Tests that exercised the externally-supplied infinity flag have been dropped since the flag no longer exists; (0,0)-roundtrip cases are kept.
Acir::MemOp no longer accepts Expression-shaped index/value after the serialization change; mem_op_to_acir_mem_op now asserts both are witnesses. The ROM/RAM/CallData test configs that exercised constant ops (perform_constant_ops = true) round-trip through that helper and trip the assertion, so drop those configs together with the unused add_constant_ops helper and template flag.
EmbeddedCurveAdd dropped is_infinite in 4992cb1, so each MSM point is now two field elements and the output is (x, y). The two size assertions were missed in that change; update them to match.
EmbeddedCurveAdd/MSM dropped is_infinite from points (4992cb1). The constraint now uses 6 fewer gates for MSM and 8 fewer for EcAdd, so update the opcode-gate-count expectations to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch brings together two PRs:
chore!: remove is_infinite from EmbeddedCurvePointis_infiniteflag from point coordinates #22564: Top of large stack which removesis_infiniteflag from AVM opcode and point structPR 1 requires AVM changes in 2 to run (since it removes the
infflag from ACIR). For more details on specific changes see the relevant PRs above.Note that 1 is applied first so this PR will initially be identical to it, apart from any changes needed from targeting the AVM merge train.
Will close:
(0, 0)is_infiniteflagThese issues form the bulk of the project: Align Circuit Point Infinity Representation with Noir + BB