Skip to content

fix: Add generic to ebike generic sprite name#10

Closed
marius-at-atb wants to merge 1 commit into
mainfrom
marius/ebike-generic-rename-fix
Closed

fix: Add generic to ebike generic sprite name#10
marius-at-atb wants to merge 1 commit into
mainfrom
marius/ebike-generic-rename-fix

Conversation

@marius-at-atb
Copy link
Copy Markdown
Collaborator

@marius-at-atb marius-at-atb commented Apr 10, 2026

After AtB-AS/mittatb-app#5882, the app expects the generic ebike sprite names to include generic.
This PR adds that.

@adriansberg
Copy link
Copy Markdown
Contributor

Should the "generic" part of the names come before the modifiers or what to call them ("selected", "minimized", "default") instead of at the end? I guess the "generic" points to the type of ebike?

@marius-at-atb
Copy link
Copy Markdown
Collaborator Author

generic means non-specific brand. Currently other options are ryde, voi and dott.
We have this issue to complete it for ebikes, the same as we have for e scooters:

@adriansberg
Copy link
Copy Markdown
Contributor

adriansberg commented Apr 16, 2026

generic means non-specific brand. Currently other options are ryde, voi and dott.

I see the other brands are at the end (before dark/light) as well 👍

@marius-at-atb
Copy link
Copy Markdown
Collaborator Author

Replaced by #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants