Skip to content

[PWGCF] jEPFlowAnalysis.cxx: define a new configurable axis of pseudorapidity and add one more dimension to the scalar product histograms#16187

Merged
wenyaCern merged 5 commits into
AliceO2Group:masterfrom
jikim1290:cf1
May 12, 2026
Merged

[PWGCF] jEPFlowAnalysis.cxx: define a new configurable axis of pseudorapidity and add one more dimension to the scalar product histograms#16187
wenyaCern merged 5 commits into
AliceO2Group:masterfrom
jikim1290:cf1

Conversation

@jikim1290
Copy link
Copy Markdown
Contributor

@jikim1290 jikim1290 commented May 11, 2026

define a new configurable axis of pseudorapidity
add one more dimension to the scalar product histograms

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

O2 linter results: ❌ 0 errors, ⚠️ 3 warnings, 🔕 0 disabled

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 11, 2026

@jikim1290 Please make it clear in your PR title which part of the framework has changed.

@jikim1290
Copy link
Copy Markdown
Contributor Author

@vkucera it has been added

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 11, 2026

@vkucera it has been added

Where?

@jikim1290 jikim1290 changed the title [PWGCF] adding eta axis [PWGCF] define a new configurable axis of pseudorapidity and add one more dimension to the scalar product histograms May 11, 2026
@jikim1290
Copy link
Copy Markdown
Contributor Author

@vkucera it was updated in the main body and moved to the title

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 11, 2026

@vkucera it was updated in the main body and moved to the title

There is still no mention of the location of the changes, i.e. name of the file or the analysis or the framework feature.

@jikim1290 jikim1290 changed the title [PWGCF] define a new configurable axis of pseudorapidity and add one more dimension to the scalar product histograms [PWGCF] jEPFlowAnalysis.cxx: define a new configurable axis of pseudorapidity and add one more dimension to the scalar product histograms May 11, 2026
@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 97c75b4 at 2026-05-11 16:02:

No log files found

Full log here.

@wenyaCern
Copy link
Copy Markdown
Collaborator

Hi @jikim1290, could you fix the O2-linter errors as instructed? Thank you in advance

Comment thread PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx Outdated
jikim1290 added a commit to jikim1290/O2Physics that referenced this pull request May 12, 2026
Please consider the following formatting changes to AliceO2Group#16187
@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 5bf10a0 at 2026-05-12 12:21:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:426:33: error: 'kMinQvecAmp' was not declared in this scope; did you mean 'minQvecAmp'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:493:37: error: 'kMinChg' was not declared in this scope; did you mean 'minChg'?
ninja: build stopped: subcommand failed.

Full log here.

jikim1290 added a commit to jikim1290/O2Physics that referenced this pull request May 12, 2026
Please consider the following formatting changes to AliceO2Group#16187
wenyaCern
wenyaCern previously approved these changes May 12, 2026
Comment thread PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx Outdated
@@ -62,6 +63,8 @@ using MyTracksMC = soa::Join<aod::Tracks, aod::TracksExtra, aod::TracksDCA, aod:

struct jEPFlowAnalysis {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the struct name.

Suggested change
struct jEPFlowAnalysis {
struct JEPFlowAnalysis {

Your task produces a device name j-e-p-flow-analysis while the workflow is called epflow-analysis.

@wenyaCern wenyaCern merged commit 427e8f4 into AliceO2Group:master May 12, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants