Skip to content

[Common] Add example mult calib for pp using derived data#16173

Merged
ddobrigk merged 2 commits intoAliceO2Group:masterfrom
ddobrigk:multCalibTask
May 8, 2026
Merged

[Common] Add example mult calib for pp using derived data#16173
ddobrigk merged 2 commits intoAliceO2Group:masterfrom
ddobrigk:multCalibTask

Conversation

@ddobrigk
Copy link
Copy Markdown
Collaborator

@ddobrigk ddobrigk commented May 8, 2026

No description provided.

@github-actions github-actions Bot added the common label May 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

O2 linter results: ❌ 3 errors, ⚠️ 4 warnings, 🔕 0 disabled

@ddobrigk ddobrigk marked this pull request as ready for review May 8, 2026 20:19
@ddobrigk ddobrigk requested review from a team, alibuild, dsekihat, iarsene, jgrosseo and ktf as code owners May 8, 2026 20:19
@ddobrigk ddobrigk enabled auto-merge (squash) May 8, 2026 20:19
Copy link
Copy Markdown
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ddobrigk.

@ddobrigk ddobrigk merged commit 63a18f6 into AliceO2Group:master May 8, 2026
13 of 15 checks passed
@ddobrigk ddobrigk deleted the multCalibTask branch May 8, 2026 21:02
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 11, 2026

Please fix the bugs:

Common/Tasks/centralityStudypp.cxx:50:26: warning: Member variable 'centralityStudypp::mRunNumber' has no initializer. [uninitMemberVarNoCtor]
Common/Tasks/centralityStudypp.cxx:50:26: warning: Member variable 'centralityStudypp::startOfRunTimestamp' has no initializer. [uninitMemberVarNoCtor]
Common/Tasks/centralityStudypp.cxx:50:26: warning: Member variable 'centralityStudypp::hCalibObjects' has no initializer. [uninitMemberVarNoCtor]
Common/Tasks/centralityStudypp.cxx:50:26: warning: Member variable 'centralityStudypp::hVtxZFV0A' has no initializer. [uninitMemberVarNoCtor]
Common/Tasks/centralityStudypp.cxx:50:26: warning: Member variable 'centralityStudypp::hVtxZFT0A' has no initializer. [uninitMemberVarNoCtor]
Common/Tasks/centralityStudypp.cxx:50:26: warning: Member variable 'centralityStudypp::hVtxZFT0C' has no initializer. [uninitMemberVarNoCtor]
Common/Tasks/centralityStudypp.cxx:50:26: warning: Member variable 'centralityStudypp::hVtxZNTracks' has no initializer. [uninitMemberVarNoCtor]
Common/Tasks/centralityStudypp.cxx:50:26: warning: Member variable 'centralityStudypp::hVtxZNGlobals' has no initializer. [uninitMemberVarNoCtor]
Common/Tasks/centralityStudypp.cxx:50:26: warning: Member variable 'centralityStudypp::hVtxZMFT' has no initializer. [uninitMemberVarNoCtor]
Common/Tasks/centralityStudypp.cxx:50:26: warning: Member variable 'centralityStudypp::hVtxZFDDA' has no initializer. [uninitMemberVarNoCtor]
Common/Tasks/centralityStudypp.cxx:50:26: warning: Member variable 'centralityStudypp::hVtxZFDDC' has no initializer. [uninitMemberVarNoCtor]
Common/Tasks/centralityStudypp.cxx:57:12: style: struct member 'centralityStudypp::startOfRunTimestamp' is never used. [unusedStructMember]
Common/Tasks/centralityStudypp.cxx:17:1: warning: included header Centrality.h is not used directly [misc-include-cleaner]
Common/Tasks/centralityStudypp.cxx:21:1: warning: included header GRPECSObject.h is not used directly [misc-include-cleaner]
Common/Tasks/centralityStudypp.cxx:37:1: warning: included header bitset is not used directly [misc-include-cleaner]
Common/Tasks/centralityStudypp.cxx:48:9: warning: function-like macro 'getHist' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
Common/Tasks/centralityStudypp.cxx:48:54: warning: macro argument should be enclosed in parentheses [bugprone-macro-parentheses]
Common/Tasks/centralityStudypp.cxx:50:8: warning: constructor does not initialize these fields: ccdb, mRunNumber, startOfRunTimestamp, hCalibObjects, hVtxZFV0A, hVtxZFT0A, hVtxZFT0C, hVtxZNTracks, hVtxZNGlobals, hVtxZMFT, hVtxZFDDA, hVtxZFDDC [cppcoreguidelines-pro-type-member-init]
Common/Tasks/centralityStudypp.cxx:176:19: warning: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast]
Common/Tasks/centralityStudypp.cxx:177:19: warning: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast]
Common/Tasks/centralityStudypp.cxx:178:19: warning: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast]
Common/Tasks/centralityStudypp.cxx:181:22: warning: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast]
Common/Tasks/centralityStudypp.cxx:182:23: warning: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast]
Common/Tasks/centralityStudypp.cxx:183:18: warning: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast]
Common/Tasks/centralityStudypp.cxx:239:44: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tasks/centralityStudypp.cxx:311:59: warning: statement should be inside braces [readability-braces-around-statements]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants