test(hpc/activations): F→C symmetric companion to sigmoid_f32 stride-order test#164
Merged
Merged
Conversation
…gmoid_f32 Adds the F-in / C-out direction to the existing test_sigmoid_f32_c_in_f_out_mismatched_strides coverage. If a future refactor accidentally guards only the asymmetric case (e.g. `if x.is_standard_layout() != out.is_standard_layout()`), the existing C→F test would still pass while F→C silently regressed. Both directions now pin the strides-equality guard symmetrically. Cherry-picked from claude/sigmoid-stride-order-fix-MAOO0-v2 (0774bdb) — the rest of that branch is a destructive rebase pre-dating Phase-2 substrate work and is not safe to land as a PR. Only the +37-line additive test makes it into this branch. Verified: 18/18 hpc::activations tests pass on master tip 25bcafb (includes both test_sigmoid_f32_c_in_f_out_mismatched_strides and the new test_sigmoid_f32_f_in_c_out_mismatched_strides).
This was referenced May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks the +37-line additive F-order test from
claude/sigmoid-stride-order-fix-MAOO0-v2(0774bdb), drops the rest. Adds the F-in / C-out symmetric counterpart to the existingtest_sigmoid_f32_c_in_f_out_mismatched_stridescoverage.If a future refactor accidentally guards only the asymmetric case (e.g.
if x.is_standard_layout() != out.is_standard_layout()), the existing C→F test would still pass while F→C silently regressed. Both directions now pin the strides-equality guard symmetrically.Why cherry-pick instead of opening the original branch
claude/sigmoid-stride-order-fix-MAOO0-v2is a destructive rebase pre-dating all of Phase-2 substrate work: +52 / −26,900 lines across 92 files. It would delete the.claude/knowledge/substrate set (GridLake, X14′, canary, hhtl-* prompts, pr-x* designs, consolidation doc), the entiresrc/hpc/linalg/*module set, the entiresrc/hpc/pillar/*module set, and the entiresrc/hpc/ogit_bridge/*module + assets.Only the +37 additive lines in
src/hpc/activations.rsare safe to land. That's what this PR contains. The destructive-rebase branch should be closed without merging.Test plan
cargo check --tests --libclean on master tip25bcafb9cargo test --lib hpc::activations→ 18/18 pass, including both:test_sigmoid_f32_c_in_f_out_mismatched_strides(existing)test_sigmoid_f32_f_in_c_out_mismatched_strides(new in this PR)Generated by Claude Code