deps: pin blake3 to std feature instead of hpc-extras#152
Merged
Conversation
The cognitive substrate modules under hpc/ — plane, seal, merkle_tree, vsa, spo_bundle, crystal_encoder, compression_curves, deepnsm — import blake3 directly and unconditionally. Gating blake3 behind `hpc-extras` caused recurring "missing blake3" build errors for consumers (e.g. burn-ndarray) that selected `default-features = false, features = ["std"]` to shed the p64/fractal dependency tree. Pinning blake3 to the `std` feature removes the footgun: any std-enabled build automatically gets blake3 with zero additional feature wiring. The nostd build (`thumbv6m-none-eabi --no-default-features`) is unaffected — no `std`, no blake3, no `constant_time_eq` non-no_std transitive issue. Both build paths verified locally with `cargo check`. Prominent documentation added in three places (Cargo.toml comment block, src/lib.rs `pub mod hpc` doc, README.md Requirements section) to prevent this from being silently un-done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cognitive substrate modules under hpc/ — plane, seal, merkle_tree, vsa, spo_bundle, crystal_encoder, compression_curves, deepnsm — import blake3 directly and unconditionally. Gating blake3 behind
hpc-extrascaused recurring "missing blake3" build errors for consumers (e.g. burn-ndarray) that selecteddefault-features = false, features = ["std"]to shed the p64/fractal dependency tree. Pinning blake3 to thestdfeature removes the footgun: any std-enabled build automatically gets blake3 with zero additional feature wiring.The nostd build (
thumbv6m-none-eabi --no-default-features) is unaffected — nostd, no blake3, noconstant_time_eqnon-no_std transitive issue. Both build paths verified locally withcargo check.Prominent documentation added in three places (Cargo.toml comment block, src/lib.rs
pub mod hpcdoc, README.md Requirements section) to prevent this from being silently un-done.