Skip to content

Clang format fix#2018

Merged
jminor merged 3 commits intoAcademySoftwareFoundation:mainfrom
jminor:clang-format-fix
Apr 28, 2026
Merged

Clang format fix#2018
jminor merged 3 commits intoAcademySoftwareFoundation:mainfrom
jminor:clang-format-fix

Conversation

@jminor
Copy link
Copy Markdown
Collaborator

@jminor jminor commented Apr 28, 2026

The Makefile format rule had some mistakes that prevented make format from applying the clang-format rules to all of the source files. This PR fixes the Makefile and applies the current clang-format rules to all the .cpp and .h source files that were previously missed.

jminor added 3 commits April 27, 2026 17:32
Signed-off-by: Joshua Minor <joshm@pixar.com>
Signed-off-by: Joshua Minor <joshm@pixar.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.68852% with 169 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.50%. Comparing base (6e13de4) to head (e61f00c).

Files with missing lines Patch % Lines
src/opentimelineio/algo/editAlgorithm.cpp 0.00% 75 Missing ⚠️
...ntimelineio/opentimelineio-bindings/otio_imath.cpp 64.06% 23 Missing ⚠️
...lineio/opentime-bindings/opentime_rationalTime.cpp 84.09% 21 Missing ⚠️
...pentimelineio-bindings/otio_errorStatusHandler.cpp 76.78% 13 Missing ⚠️
...ntimelineio/opentimelineio-bindings/otio_tests.cpp 65.78% 13 Missing ⚠️
...ntimelineio/opentimelineio-bindings/otio_utils.cpp 84.88% 13 Missing ⚠️
...pentimelineio/opentimelineio-bindings/otio_utils.h 87.17% 5 Missing ⚠️
...melineio/opentimelineio-bindings/otio_bindings.cpp 98.27% 2 Missing ⚠️
...imelineio/opentime-bindings/opentime_timeRange.cpp 98.91% 1 Missing ⚠️
...ineio/opentime-bindings/opentime_timeTransform.cpp 96.15% 1 Missing ⚠️
... and 2 more

❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2018      +/-   ##
==========================================
- Coverage   85.14%   84.50%   -0.65%     
==========================================
  Files         181      181              
  Lines       12780    13223     +443     
  Branches     1206     1202       -4     
==========================================
+ Hits        10882    11174     +292     
- Misses       1715     1866     +151     
  Partials      183      183              
Flag Coverage Δ
py-unittests 84.50% <78.68%> (-0.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...timelineio/opentime-bindings/opentime_bindings.cpp 100.00% <100.00%> (ø)
...ineio/opentimelineio-bindings/otio_anyDictionary.h 100.00% <100.00%> (ø)
...imelineio/opentimelineio-bindings/otio_anyVector.h 100.00% <100.00%> (ø)
.../opentimelineio-bindings/otio_errorStatusHandler.h 100.00% <100.00%> (ø)
...entimelineio-bindings/otio_serializableObjects.cpp 83.20% <ø> (-12.16%) ⬇️
...imelineio/opentime-bindings/opentime_timeRange.cpp 99.00% <98.91%> (+0.97%) ⬆️
...ineio/opentime-bindings/opentime_timeTransform.cpp 96.87% <96.15%> (-3.13%) ⬇️
...eio/opentimelineio-bindings/otio_anyDictionary.cpp 93.75% <87.50%> (-6.25%) ⬇️
...elineio/opentimelineio-bindings/otio_anyVector.cpp 94.11% <87.50%> (-5.89%) ⬇️
...melineio/opentimelineio-bindings/otio_bindings.cpp 98.63% <98.27%> (+0.23%) ⬆️
... and 7 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e13de4...e61f00c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jminor jminor requested a review from darbyjohnston April 28, 2026 00:45
@darbyjohnston
Copy link
Copy Markdown
Contributor

The Makefile changes look fine, I honestly didn't review all of the code changes...

@jminor jminor merged commit 05416ab into AcademySoftwareFoundation:main Apr 28, 2026
55 checks passed
@jminor jminor mentioned this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants